Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Issue 2109593007: Remove SpdyNetworkTransactionTestSSLType. (Closed)

Created:
4 years, 5 months ago by Bence
Modified:
4 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SpdyNetworkTransactionTestSSLType. HTTP_SPDY_VIA_NPN and HTTPS_SPDY_VIA_ALT_SVC type tests use the same origin, same port, same scheme. The only different is the preloaded alternative service record and the extra hanging socket. There is really no added value, it is just a burden on code complexity and test infrastructure. Committed: https://crrev.com/f23de8c58bd85a39611c60960fde9a6bf6dd9473 Cr-Commit-Position: refs/heads/master@{#403226}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -92 lines) Patch
M net/spdy/spdy_network_transaction_unittest.cc View 11 chunks +6 lines, -92 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Bence
Ryan: PTAL. Thank you.
4 years, 5 months ago (2016-06-30 17:53:33 UTC) #2
Ryan Hamilton
lgtm Do we have a "HTTP/2 via remote Alt-Svc" test somewhere? (I think we do).
4 years, 5 months ago (2016-06-30 18:09:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109593007/1
4 years, 5 months ago (2016-06-30 18:13:22 UTC) #5
Bence
On 2016/06/30 18:09:51, Ryan Hamilton wrote: > lgtm > > Do we have a "HTTP/2 ...
4 years, 5 months ago (2016-06-30 18:18:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 18:21:23 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 18:21:37 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f23de8c58bd85a39611c60960fde9a6bf6dd9473 Cr-Commit-Position: refs/heads/master@{#403226}
4 years, 5 months ago (2016-06-30 18:25:47 UTC) #10
Bence
4 years, 5 months ago (2016-06-30 22:35:38 UTC) #11
Message was sent while issue was closed.
FYI This CL reduces the number of net_unittests from 22496 to 22312, a modest
reduction of 0.8%.

Powered by Google App Engine
This is Rietveld 408576698