Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1309)

Unified Diff: components/mus/common/gpu_type_converters_unittest.cc

Issue 2109593006: Add ChannelHandle::mojo_handle to mus' ChannelHandle mojom. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make mojo_handle optional, which it is. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/mus/common/gpu_type_converters_unittest.cc
diff --git a/components/mus/common/gpu_type_converters_unittest.cc b/components/mus/common/gpu_type_converters_unittest.cc
index 012664309d909bbc17b0b759baf8c39e8541d642..a3429e3c64802027e52693b1cada79e5e3b7cf3b 100644
--- a/components/mus/common/gpu_type_converters_unittest.cc
+++ b/components/mus/common/gpu_type_converters_unittest.cc
@@ -57,6 +57,28 @@ TEST(MusGpuTypeConvertersTest, ChannelHandle) {
base::ScopedFD socped_fd3(handle.socket.fd);
}
#endif
+
+ {
+ const std::string channel_name = "test_channel_name";
+ mojo::MessagePipe message_pipe;
+ mojo::MessagePipeHandle mp_handle = message_pipe.handle0.release();
+ EXPECT_TRUE(mp_handle.is_valid());
+ IPC::ChannelHandle handle(mp_handle);
+ handle.name = channel_name;
+
+ mus::mojom::ChannelHandlePtr mojo_handle =
+ mus::mojom::ChannelHandle::From(handle);
+ ASSERT_EQ(mojo_handle->name, channel_name);
+ ASSERT_EQ(mojo_handle->mojo_handle.get(), mp_handle);
+ EXPECT_FALSE(mojo_handle->socket.is_valid());
+
+ handle = mojo_handle.To<IPC::ChannelHandle>();
+ ASSERT_EQ(handle.name, channel_name);
+ ASSERT_EQ(handle.mojo_handle, mp_handle);
+#if defined(OS_POSIX)
+ ASSERT_EQ(handle.socket.fd, -1);
+#endif
+ }
}
// Test for mojo TypeConverter of mus::mojom::GpuMemoryBufferHandle

Powered by Google App Engine
This is Rietveld 408576698