Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1606)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2109593003: Update status for failing and flaky tests. (Closed)

Created:
4 years, 5 months ago by Bill Hesse
Modified:
4 years, 5 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update win8 ie11 status diff from win7 ie11. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -19 lines) Patch
M pkg/pkg.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 7 chunks +16 lines, -13 lines 0 comments Download
M tests/compiler/dart2js/serialization/compilation1_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/serialization/compilation2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/compiler/dart2js/serialization/compilation3_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/compiler/dart2js/serialization/compilation4_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/html.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Bill Hesse
4 years, 5 months ago (2016-06-29 10:52:18 UTC) #2
Søren Gjesse
https://codereview.chromium.org/2109593003/diff/1/tests/compiler/dart2js/serialization/compilation1_test.dart File tests/compiler/dart2js/serialization/compilation1_test.dart (right): https://codereview.chromium.org/2109593003/diff/1/tests/compiler/dart2js/serialization/compilation1_test.dart#newcode11 tests/compiler/dart2js/serialization/compilation1_test.dart:11: test.main(['0', '${TESTS.length ~/ 4}']); What is this change about?
4 years, 5 months ago (2016-06-29 11:32:14 UTC) #3
Bill Hesse
https://codereview.chromium.org/2109593003/diff/1/tests/compiler/dart2js/serialization/compilation1_test.dart File tests/compiler/dart2js/serialization/compilation1_test.dart (right): https://codereview.chromium.org/2109593003/diff/1/tests/compiler/dart2js/serialization/compilation1_test.dart#newcode11 tests/compiler/dart2js/serialization/compilation1_test.dart:11: test.main(['0', '${TESTS.length ~/ 4}']); On 2016/06/29 11:32:14, Søren Gjesse ...
4 years, 5 months ago (2016-06-29 12:10:27 UTC) #4
Bill Hesse
On 2016/06/29 12:10:27, Bill Hesse wrote: > https://codereview.chromium.org/2109593003/diff/1/tests/compiler/dart2js/serialization/compilation1_test.dart > File tests/compiler/dart2js/serialization/compilation1_test.dart (right): > > https://codereview.chromium.org/2109593003/diff/1/tests/compiler/dart2js/serialization/compilation1_test.dart#newcode11 ...
4 years, 5 months ago (2016-06-29 13:32:35 UTC) #5
Søren Gjesse
lgtm
4 years, 5 months ago (2016-06-29 15:32:54 UTC) #6
Bill Hesse
4 years, 5 months ago (2016-06-29 20:42:57 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
f36b49f8f3689b730f65d7b4d036e663f9dc6c1f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698