Quick View: Add more metadata and update UI.

Quick View: Add more metadata and update UI.

Added imageHeight, imageWidth, mediaArtist, mediaTitle and mediaMimeType.
Also added strings for metadata which will be implemented later.

Demo: https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhMDU4bGhTNW5CbDg/view?usp=sharing

BUG=613465, 624129
TEST=manually.

Committed: https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025
Cr-Commit-Position: refs/heads/master@{#403389}

[oka, 2016-06-29 07:35:16]

Update.

[oka, 2016-06-29 07:39:09]

nit

[oka, 2016-06-29 08:24:41]

nit

[oka, 2016-06-29 08:46:48]

nit,

[oka, 2016-06-29 08:51:41]

Description was changed from

==========
WIP: more metadata.

BUG=613465
TEST=manually.
==========

to

==========
Quick View: Add more metadata and update UI.

Added imageHeight, imageWidth, mediaArtist, mediaTitle and mediaMimeType.
Also added strings for metadata which will be implemented later.

BUG=613465,624129
TEST=manually.
==========

[oka, 2016-06-29 09:17:05]

Description was changed from

==========
Quick View: Add more metadata and update UI.

Added imageHeight, imageWidth, mediaArtist, mediaTitle and mediaMimeType.
Also added strings for metadata which will be implemented later.

BUG=613465,624129
TEST=manually.
==========

to

==========
Quick View: Add more metadata and update UI.

Added imageHeight, imageWidth, mediaArtist, mediaTitle and mediaMimeType.
Also added strings for metadata which will be implemented later.

Demo:
https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhMDU4bGhTNW5CbDg/vie...

BUG=613465,624129
TEST=manually.
==========

[oka, 2016-06-29 09:17:17]

oka@chromium.org changed reviewers:
+ fukino@chromium.org

[oka, 2016-06-29 09:17:18]

PTAL.

[oka, 2016-06-29 21:15:26]

PTAL!

[fukino, 2016-06-30 03:05:05]

lgtm with nits

https://codereview.chromium.org/2109563002/diff/80001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/elements/files_quick_view.css
(right):

https://codereview.chromium.org/2109563002/diff/80001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_quick_view.css:89:
--paper-toolbar-background: rgba(60, 60, 64, 1);
rgb(60, 60, 60)

https://codereview.chromium.org/2109563002/diff/80001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_quick_view.css:166:
height: 134px;
off indent & sort

https://codereview.chromium.org/2109563002/diff/80001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/metadata_box_controller.js
(right):

https://codereview.chromium.org/2109563002/diff/80001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/metadata_box_controller.js:114:
this.metadataModel_
off indent

https://codereview.chromium.org/2109563002/diff/80001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/metadata_box_controller.js:121:
this.metadataModel_
ditto

[oka, 2016-06-30 07:36:58]

Address comments.

[oka, 2016-06-30 07:44:01]

The CQ bit was checked by oka@chromium.org

[oka, 2016-06-30 07:44:01]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2109563002/#ps100001
(title: "Address comments.")

[oka, 2016-06-30 07:44:07]

https://codereview.chromium.org/2109563002/diff/80001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/elements/files_quick_view.css
(right):

https://codereview.chromium.org/2109563002/diff/80001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_quick_view.css:89:
--paper-toolbar-background: rgba(60, 60, 64, 1);
On 2016/06/30 03:05:05, fukino wrote:
> rgb(60, 60, 60)

Done.

https://codereview.chromium.org/2109563002/diff/80001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_quick_view.css:166:
height: 134px;
On 2016/06/30 03:05:05, fukino wrote:
> off indent & sort 

Done.

https://codereview.chromium.org/2109563002/diff/80001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/metadata_box_controller.js
(right):

https://codereview.chromium.org/2109563002/diff/80001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/metadata_box_controller.js:114:
this.metadataModel_
On 2016/06/30 03:05:05, fukino wrote:
> off indent

Done.

https://codereview.chromium.org/2109563002/diff/80001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/metadata_box_controller.js:121:
this.metadataModel_
On 2016/06/30 03:05:05, fukino wrote:
> ditto

Done.

[commit-bot: I haz the power, 2016-06-30 07:44:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 08:31:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 08:31:54]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oka, 2016-06-30 12:04:42]

The CQ bit was checked by oka@chromium.org

[commit-bot: I haz the power, 2016-06-30 12:04:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 12:32:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 12:32:41]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oka, 2016-06-30 12:38:25]

Rebase

[oka, 2016-06-30 12:41:15]

The CQ bit was checked by oka@chromium.org

[oka, 2016-06-30 12:41:15]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2109563002/#ps120001
(title: "Rebase")

[commit-bot: I haz the power, 2016-06-30 12:41:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 13:09:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 13:09:09]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oka, 2016-06-30 14:00:07]

The CQ bit was checked by oka@chromium.org

[commit-bot: I haz the power, 2016-06-30 14:00:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 14:29:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 14:29:43]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oka, 2016-06-30 14:49:14]

The CQ bit was checked by oka@chromium.org

[commit-bot: I haz the power, 2016-06-30 14:49:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2016-06-30 15:08:33]

Rebase

[oka, 2016-06-30 15:47:11]

The CQ bit was checked by oka@chromium.org

[oka, 2016-06-30 15:47:12]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2109563002/#ps140001
(title: "Rebase")

[commit-bot: I haz the power, 2016-06-30 15:47:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 16:15:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 16:16:00]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oka, 2016-06-30 17:30:28]

The CQ bit was checked by oka@chromium.org

[commit-bot: I haz the power, 2016-06-30 17:31:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 18:11:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 18:11:17]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oka, 2016-06-30 22:59:52]

Remove unneeded strings

[oka, 2016-06-30 23:00:18]

The CQ bit was checked by oka@chromium.org

[oka, 2016-06-30 23:00:18]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2109563002/#ps160001
(title: "Remove unneeded strings")

[commit-bot: I haz the power, 2016-06-30 23:00:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 23:19:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 23:19:12]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oka, 2016-06-30 23:24:09]

nit,

[oka, 2016-06-30 23:26:57]

fix

[oka, 2016-06-30 23:28:36]

fix

[oka, 2016-06-30 23:29:22]

The CQ bit was checked by oka@chromium.org

[oka, 2016-06-30 23:29:22]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2109563002/#ps220001
(title: "fix")

[commit-bot: I haz the power, 2016-06-30 23:30:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 00:03:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-01 00:03:24]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oka, 2016-07-01 00:31:45]

Increment resource ID

[oka, 2016-07-01 00:33:05]

oka@chromium.org changed reviewers:
+ thestig@chromium.org

[oka, 2016-07-01 00:33:06]

thestig@ PTAL.

[Lei Zhang, 2016-07-01 00:41:37]

I suspect the resource_ids change is wrong. Please try reverting the
resource_ids changes and only make the changes suggested below. I think that
should work for this CL.

If you plan to add many more resources to
ui/file_manager/file_manager_resources.grd in the future, we should talk about
the lack of resource ids.

https://codereview.chromium.org/2109563002/diff/240001/tools/gritsettings/res...
File tools/gritsettings/resource_ids (right):

https://codereview.chromium.org/2109563002/diff/240001/tools/gritsettings/res...
tools/gritsettings/resource_ids:263: "includes": [26860],
Leave this at 26760.

https://codereview.chromium.org/2109563002/diff/240001/tools/gritsettings/res...
tools/gritsettings/resource_ids:266: "includes": [27040],
Change this to 26945.

[oka, 2016-07-01 00:54:38]

Address comments.

[oka, 2016-07-01 00:55:02]

PTAL. Thanks

[oka, 2016-07-01 00:57:39]

https://codereview.chromium.org/2109563002/diff/240001/tools/gritsettings/res...
File tools/gritsettings/resource_ids (right):

https://codereview.chromium.org/2109563002/diff/240001/tools/gritsettings/res...
tools/gritsettings/resource_ids:263: "includes": [26860],
On 2016/07/01 00:41:37, Lei Zhang wrote:
> Leave this at 26760.

Done.

https://codereview.chromium.org/2109563002/diff/240001/tools/gritsettings/res...
tools/gritsettings/resource_ids:266: "includes": [27040],
On 2016/07/01 00:41:37, Lei Zhang wrote:
> Change this to 26945.

Done.

[Lei Zhang, 2016-07-01 00:58:16]

lgtm, let's see how the trybots behave. Hopefully I gave good advice.

[oka, 2016-07-01 01:19:27]

The CQ bit was checked by oka@chromium.org

[oka, 2016-07-01 01:19:28]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2109563002/#ps260001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-07-01 01:19:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 02:01:04]

Description was changed from

==========
Quick View: Add more metadata and update UI.

Added imageHeight, imageWidth, mediaArtist, mediaTitle and mediaMimeType.
Also added strings for metadata which will be implemented later.

Demo:
https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhMDU4bGhTNW5CbDg/vie...

BUG=613465,624129
TEST=manually.
==========

to

==========
Quick View: Add more metadata and update UI.

Added imageHeight, imageWidth, mediaArtist, mediaTitle and mediaMimeType.
Also added strings for metadata which will be implemented later.

Demo:
https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhMDU4bGhTNW5CbDg/vie...

BUG=613465,624129
TEST=manually.
==========

[commit-bot: I haz the power, 2016-07-01 02:01:06]

Committed patchset #14 (id:260001)

[commit-bot: I haz the power, 2016-07-01 02:03:00]

Description was changed from

==========
Quick View: Add more metadata and update UI.

Added imageHeight, imageWidth, mediaArtist, mediaTitle and mediaMimeType.
Also added strings for metadata which will be implemented later.

Demo:
https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhMDU4bGhTNW5CbDg/vie...

BUG=613465,624129
TEST=manually.
==========

to

==========
Quick View: Add more metadata and update UI.

Added imageHeight, imageWidth, mediaArtist, mediaTitle and mediaMimeType.
Also added strings for metadata which will be implemented later.

Demo:
https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhMDU4bGhTNW5CbDg/vie...

BUG=613465,624129
TEST=manually.

Committed: https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025
Cr-Commit-Position: refs/heads/master@{#403389}
==========

[commit-bot: I haz the power, 2016-07-01 02:03:02]

Patchset 14 (id:??) landed as
https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025
Cr-Commit-Position: refs/heads/master@{#403389}