Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Unified Diff: src/wasm/wasm-js.cc

Issue 2109533002: [wasm] Require wasm explicit asm instantiation to be of a function. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-wasm-crbug-620649.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/wasm-js.cc
diff --git a/src/wasm/wasm-js.cc b/src/wasm/wasm-js.cc
index 6dc14952a01e943b8bd5a9fc012c8d648c59dbae..bcccf2e3ebcd4a10c454392f5b1530a9405a2ef1 100644
--- a/src/wasm/wasm-js.cc
+++ b/src/wasm/wasm-js.cc
@@ -141,6 +141,11 @@ v8::internal::wasm::ZoneBuffer* TranslateAsmModule(
return nullptr;
}
+ if (!info->scope()->declarations()->at(0)->IsFunctionDeclaration()) {
+ thrower->Error("Asm.js validation failed: non-function declaration");
+ return nullptr;
+ }
+
info->set_literal(
info->scope()->declarations()->at(0)->AsFunctionDeclaration()->fun());
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-wasm-crbug-620649.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698