Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2109533002: [wasm] Require wasm explicit asm instantiation to be of a function. (Closed)

Created:
4 years, 5 months ago by bradnelson
Modified:
4 years, 5 months ago
Reviewers:
aseemgarg, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Require wasm explicit asm instantiation to be of a function. We were not checking that the string passed to instantiateFromAsm contains a function declaration (any declaration was allowed). Fixes crash. BUG=620649 BUG=v8:4203 R=aseemgarg@chromium.org Committed: https://crrev.com/58920e04bce8435be4c98e36b3c10592ef1b206d Cr-Commit-Position: refs/heads/master@{#37349}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M src/wasm/wasm-js.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-wasm-crbug-620649.js View 1 chunk +10 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bradnelson
4 years, 5 months ago (2016-06-28 06:59:18 UTC) #1
aseemgarg
lgtm
4 years, 5 months ago (2016-06-28 18:45:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109533002/1
4 years, 5 months ago (2016-06-28 20:55:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 20:57:36 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 20:58:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58920e04bce8435be4c98e36b3c10592ef1b206d
Cr-Commit-Position: refs/heads/master@{#37349}

Powered by Google App Engine
This is Rietveld 408576698