Clean up some "GetProperty" methods/functions.

Clean up some "GetProperty" methods/functions.

Runtime::GetObjectProperty:
  - handled string.charAt, element access and property access
  - now handlified
GetProperty in handles.cc:
  - called to Runtime::GetObjectProperty
  - now removed
Object::GetProperty (handlified version):
  - handled element access and property access
  - now changed to only do property access
New: Object::GetPropertyOrElement:
  - handles element access and property access

R=ishell@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20327

[Igor Sheludko, 2014-03-26 18:37:31]

If the comments do not make sense then lgtm.

https://codereview.chromium.org/210953005/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/210953005/diff/1/src/bootstrapper.cc#newcode1941
src/bootstrapper.cc:1941: Handle<JSFunction>::cast(Object::GetProperty(
We don't need all the checks performed by Runtime::GetObjectProperty() for
global objects. Right?

https://codereview.chromium.org/210953005/diff/1/src/execution.cc
File src/execution.cc (right):

https://codereview.chromium.org/210953005/diff/1/src/execution.cc#newcode786
src/execution.cc:786: Handle<Object> char_at = Object::GetProperty(
We don't need all the checks done by Runtime::GetObjectProperty() for js
builtins object. Right?

https://codereview.chromium.org/210953005/diff/1/src/json-stringifier.h
File src/json-stringifier.h (right):

https://codereview.chromium.org/210953005/diff/1/src/json-stringifier.h#newco...
src/json-stringifier.h:660: for (int i = 0; i < map->NumberOfOwnDescriptors();
i++) {
Shouldn't we create a HandleScope here inside the loop?

https://codereview.chromium.org/210953005/diff/1/src/json-stringifier.h#newco...
src/json-stringifier.h:687: for (int i = 0; i < contents->length(); i++) {
And here?

https://codereview.chromium.org/210953005/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/210953005/diff/1/src/objects.cc#newcode3606
src/objects.cc:3606: Handle<Object> configurable = Object::GetProperty(desc,
configurable_name);
Is it possible to get undefined or null as a desc here? If not is it worth
ASSERTing about that?

https://codereview.chromium.org/210953005/diff/1/src/objects.cc#newcode3741
src/objects.cc:3741: RETURN_IF_EMPTY_HANDLE_VALUE(isolate, setter, NONE);
Add two spaces in front of the line.

[Yang, 2014-03-28 09:49:40]

Committed patchset #2 manually as r20327 (presubmit successful).

[Yang, 2014-03-28 09:56:58]

https://codereview.chromium.org/210953005/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/210953005/diff/1/src/bootstrapper.cc#newcode1941
src/bootstrapper.cc:1941: Handle<JSFunction>::cast(Object::GetProperty(
On 2014/03/26 18:37:31, Igor Sheludko wrote:
> We don't need all the checks performed by Runtime::GetObjectProperty() for
> global objects. Right?

Right. The object is the global object (not a string), and the key is not a
number.

https://codereview.chromium.org/210953005/diff/1/src/execution.cc
File src/execution.cc (right):

https://codereview.chromium.org/210953005/diff/1/src/execution.cc#newcode786
src/execution.cc:786: Handle<Object> char_at = Object::GetProperty(
On 2014/03/26 18:37:31, Igor Sheludko wrote:
> We don't need all the checks done by Runtime::GetObjectProperty() for js
> builtins object. Right?

Right.

https://codereview.chromium.org/210953005/diff/1/src/json-stringifier.h
File src/json-stringifier.h (right):

https://codereview.chromium.org/210953005/diff/1/src/json-stringifier.h#newco...
src/json-stringifier.h:660: for (int i = 0; i < map->NumberOfOwnDescriptors();
i++) {
On 2014/03/26 18:37:31, Igor Sheludko wrote:
> Shouldn't we create a HandleScope here inside the loop?

No. This is working as intended. The string we are dumping to may be
extended/reallocated as we go. So if we had a new handle scope in each loop, we
would also have to escape the handle in each loop, like at the end of this
function. The way it currently is works fine, we can change it if it turns out
to be a problem at some point.

https://codereview.chromium.org/210953005/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/210953005/diff/1/src/objects.cc#newcode3606
src/objects.cc:3606: Handle<Object> configurable = Object::GetProperty(desc,
configurable_name);
On 2014/03/26 18:37:31, Igor Sheludko wrote:
> Is it possible to get undefined or null as a desc here? If not is it worth
> ASSERTing about that?

I think it's alright the way it is. This is purely mechanical after all.

https://codereview.chromium.org/210953005/diff/1/src/objects.cc#newcode3741
src/objects.cc:3741: RETURN_IF_EMPTY_HANDLE_VALUE(isolate, setter, NONE);
On 2014/03/26 18:37:31, Igor Sheludko wrote:
> Add two spaces in front of the line.

Done.