Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 210953003: Make style independent of the presence of the <shadow> element. (Closed)

Created:
6 years, 9 months ago by tasak
Modified:
6 years, 9 months ago
Reviewers:
esprehn, dglazkov
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, rune+blink, Inactive, rwlbuis
Visibility:
Public.

Description

Make style independent of the presence of the <shadow> element. BUG=353406 TEST=fast/dom/shadow/style-and-shadow-element.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170091

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -96 lines) Patch
D LayoutTests/fast/dom/shadow/content-pseudo-element-in-inert-shadow.html View 1 chunk +0 lines, -49 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-in-inert-shadow-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-in-older-shadow.html View 3 chunks +5 lines, -6 lines 0 comments Download
A LayoutTests/fast/dom/shadow/content-pseudo-element-in-older-shadow-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/style-and-shadow-element.html View 1 1 chunk +98 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/style-and-shadow-element-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/style-with-cat.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/shadow/style-with-cat-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/style-with-hat.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/shadow/style-with-hat-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/ScopedStyleTree.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/shadow/ShadowRoot.cpp View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tasak
Would you review this CL? This patch is just for mainly removing ShadowRoot::isActiveForStyling().
6 years, 9 months ago (2014-03-26 12:03:29 UTC) #1
dglazkov
lgtm
6 years, 9 months ago (2014-03-26 16:42:06 UTC) #2
esprehn
lgtm
6 years, 9 months ago (2014-03-26 20:02:08 UTC) #3
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-26 20:02:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/210953003/20001
6 years, 9 months ago (2014-03-26 20:02:18 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 20:12:38 UTC) #6
Message was sent while issue was closed.
Change committed as 170091

Powered by Google App Engine
This is Rietveld 408576698