Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 2109503002: Use saturated_cast<> instead of checked_cast<> for converting (Closed)

Created:
4 years, 5 months ago by eroman
Modified:
4 years, 5 months ago
Reviewers:
gavinp
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, kinuko+cache_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use saturated_cast<> instead of checked_cast<> for converting base::Time() to a unix timestamp. BUG=543469 Committed: https://crrev.com/2cc02aa58968ce806ebe42254fd2490448474f15 Cr-Commit-Position: refs/heads/master@{#402497}

Patch Set 1 #

Patch Set 2 : checkpoint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M net/disk_cache/simple/simple_index.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/simple/simple_index_unittest.cc View 1 2 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
eroman
4 years, 5 months ago (2016-06-28 05:06:23 UTC) #2
gavinp
lgtm. Good catch.
4 years, 5 months ago (2016-06-28 13:58:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109503002/20001
4 years, 5 months ago (2016-06-28 17:18:58 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-28 17:24:44 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 17:26:31 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2cc02aa58968ce806ebe42254fd2490448474f15
Cr-Commit-Position: refs/heads/master@{#402497}

Powered by Google App Engine
This is Rietveld 408576698