Issue 21095003: Early return if animations should not apply in resetAnimatedType()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21095003: Early return if animations should not apply in resetAnimatedType() (Closed)

Created:
7 years, 4 months ago by pdr.

Modified:
7 years, 4 months ago

Reviewers:
leviw_travelin_and_unemployed, fmalita_google_do_not_use

CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), eae+blinkwatch, dglazkov+blink, dstockwell, Timothy Loh, f(malita), darktears, pdr, Stephen Chennney, Steve Block, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Early return if animations should not apply in resetAnimatedType() This is a merge of a change by Renata Hodovan in wkbug.com/118744 This patch early-returns if animations should not apply in SVGAnimateElement::resetAnimatedType, preventing an assert in SVGAniamtedType::valueAsString. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155093

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -0 lines)			Patch
A	LayoutTests/svg/animations/attributeNameAndAttributeTypeMismatch.html	View	1 chunk	+9 lines, -0 lines	0 comments	Download
A	LayoutTests/svg/animations/attributeNameAndAttributeTypeMismatch-expected.html	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	Source/core/svg/SVGAnimateElement.cpp	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/21095003/1

7 years, 4 months ago (2013-07-29 17:52:02 UTC) #3

Message was sent while issue was closed.

Change committed as 155093

Expand Messages | Collapse Messages