src/js/collection.js - Issue 2109483004: [builtins] Drop the special MathRandomRaw.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/collection.js

Issue 2109483004: [builtins] Drop the special MathRandomRaw. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/js/collection.js

diff --git a/src/js/collection.js b/src/js/collection.js

index bbb7ed247bb5d851b4e96d5b1f64e87ea412f9c9..0b3a39511fdadabf67ac6497eec475990ab77a2d 100644

--- a/src/js/collection.js

+++ b/src/js/collection.js

@@ -14,7 +14,7 @@ var GlobalMap = global.Map;

var GlobalObject = global.Object;

var GlobalSet = global.Set;

var hashCodeSymbol = utils.ImportNow("hash_code_symbol");

-var IntRandom;

+var MathRandom;

var MakeTypeError;

var MapIterator;

var NumberIsNaN;

@@ -23,7 +23,7 @@ var speciesSymbol = utils.ImportNow("species_symbol");

var toStringTagSymbol = utils.ImportNow("to_string_tag_symbol");

utils.Import(function(from) {

- IntRandom = from.IntRandom;

+ MathRandom = from.MathRandom;

MakeTypeError = from.MakeTypeError;

MapIterator = from.MapIterator;

NumberIsNaN = from.NumberIsNaN;

@@ -113,7 +113,7 @@ function GetExistingHash(key) {

function GetHash(key) {

var hash = GetExistingHash(key);

if (IS_UNDEFINED(hash)) {

- hash = IntRandom() | 0;

+ hash = (MathRandom() * 0x3FFFFFFF) | 0;

Yang 2016/06/29 05:53:42 MathRandom returns everything from 0 inclusive to

Benedikt Meurer 2016/06/29 05:54:41 Done.

if (hash === 0) hash = 1;

SET_PRIVATE(key, hashCodeSymbol, hash);

}

« no previous file with comments | « no previous file | src/js/math.js » ('j') | no next file with comments »