Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2109473004:
[heap] Eagerly unlink empty kHuge category from free list (Closed)
|
Created:
4 years, 5 months ago by Michael Lippautz Modified:
4 years, 5 months ago Reviewers:
ulan CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[heap] Eagerly unlink empty kHuge category from free list
Avoid repeatedly traversing empty kHuge empty free list categories. This is an
oversight as all other categories are already eagerly unlinked upon getting
empty (in FreeList::FindNodeIn).
R=ulan@chromium.org
Committed: https://crrev.com/aa1628ab6c90c288d43564b01e832dc2aab4961b
Cr-Commit-Position: refs/heads/master@{#37391}
Patch Set 1 #Patch Set 2 #Messages
Total messages: 22 (14 generated)
Description was changed from ========== [heap] Unlink empty kHuge category from free list BUG= ========== to ========== [heap] Unlink empty kHuge category from free list Avoid repeatedly traversing empty kHuge empty free list categories. BUG= ==========
Description was changed from ========== [heap] Unlink empty kHuge category from free list Avoid repeatedly traversing empty kHuge empty free list categories. BUG= ========== to ========== [heap] Unlink empty kHuge category from free list Avoid repeatedly traversing empty kHuge empty free list categories. BUG= ==========
Description was changed from ========== [heap] Unlink empty kHuge category from free list Avoid repeatedly traversing empty kHuge empty free list categories. BUG= ========== to ========== [heap] Unlink empty kHuge category from free list Avoid repeatedly traversing empty kHuge empty free list categories. This is an oversight as all other categories are already eagerly unlinked upon getting empty. BUG= ==========
Description was changed from ========== [heap] Unlink empty kHuge category from free list Avoid repeatedly traversing empty kHuge empty free list categories. This is an oversight as all other categories are already eagerly unlinked upon getting empty. BUG= ========== to ========== [heap] Unlink empty kHuge category from free list Avoid repeatedly traversing empty kHuge empty free list categories. This is an oversight as all other categories are already eagerly unlinked upon getting empty (in FreeList::FindNodeIn). BUG= ==========
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
Description was changed from ========== [heap] Unlink empty kHuge category from free list Avoid repeatedly traversing empty kHuge empty free list categories. This is an oversight as all other categories are already eagerly unlinked upon getting empty (in FreeList::FindNodeIn). BUG= ========== to ========== [heap] Unlink empty kHuge category from free list Avoid repeatedly traversing empty kHuge empty free list categories. This is an oversight as all other categories are already eagerly unlinked upon getting empty (in FreeList::FindNodeIn). R=ulan@chromium.org ==========
mlippautz@chromium.org changed reviewers: + ulan@chromium.org
Description was changed from ========== [heap] Unlink empty kHuge category from free list Avoid repeatedly traversing empty kHuge empty free list categories. This is an oversight as all other categories are already eagerly unlinked upon getting empty (in FreeList::FindNodeIn). R=ulan@chromium.org ========== to ========== [heap] Eagerly unlink empty kHuge category from free list Avoid repeatedly traversing empty kHuge empty free list categories. This is an oversight as all other categories are already eagerly unlinked upon getting empty (in FreeList::FindNodeIn). R=ulan@chromium.org ==========
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mlippautz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [heap] Eagerly unlink empty kHuge category from free list Avoid repeatedly traversing empty kHuge empty free list categories. This is an oversight as all other categories are already eagerly unlinked upon getting empty (in FreeList::FindNodeIn). R=ulan@chromium.org ========== to ========== [heap] Eagerly unlink empty kHuge category from free list Avoid repeatedly traversing empty kHuge empty free list categories. This is an oversight as all other categories are already eagerly unlinked upon getting empty (in FreeList::FindNodeIn). R=ulan@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [heap] Eagerly unlink empty kHuge category from free list Avoid repeatedly traversing empty kHuge empty free list categories. This is an oversight as all other categories are already eagerly unlinked upon getting empty (in FreeList::FindNodeIn). R=ulan@chromium.org ========== to ========== [heap] Eagerly unlink empty kHuge category from free list Avoid repeatedly traversing empty kHuge empty free list categories. This is an oversight as all other categories are already eagerly unlinked upon getting empty (in FreeList::FindNodeIn). R=ulan@chromium.org Committed: https://crrev.com/aa1628ab6c90c288d43564b01e832dc2aab4961b Cr-Commit-Position: refs/heads/master@{#37391} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/aa1628ab6c90c288d43564b01e832dc2aab4961b Cr-Commit-Position: refs/heads/master@{#37391} |
