Issue 2109353004: Revert "fix #25794, infer parameter type from default value"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2109353004: Revert "fix #25794, infer parameter type from default value" (Closed)

Created:
4 years, 5 months ago by Jennifer Messerly

Modified:
4 years, 5 months ago

Reviewers:
Leaf

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "fix #25794, infer parameter type from default value" It caused a regression in cyclic_default_values_test in DDC. Fixes #26785 This reverts commit d43f6870b3a47fab5da3262fe28036af7f5c6bf5. R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/ced2d0e988119e7b4366a3ccb6a931f9ac5128fd

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -75 lines)			Patch
M	pkg/analyzer/lib/src/generated/resolver.dart	View	4 chunks	+3 lines, -20 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/summarize_elements.dart	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/resynthesize_ast_test.dart	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/resynthesize_test.dart	View	2 chunks	+22 lines, -15 lines	0 comments	Download
M	pkg/analyzer/test/src/task/strong/inferred_type_test.dart	View	2 chunks	+1 line, -28 lines	0 comments	Download

Total messages: 5 (2 generated)

Jennifer Messerly

4 years, 5 months ago (2016-06-30 19:36:51 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ced2d0e988119e7b4366a3ccb6a931f9ac5128fd (presubmit successful).