Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2109353003: WebFonts intervention: exclude data url from the intervention metrics (Closed)

Created:
4 years, 5 months ago by Takashi Toyoshima
Modified:
4 years, 5 months ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebFonts intervention: exclude data url from the intervention metrics When WebFont resource is provided by data url, do not trigger the intervention, and do not report MissCachedInterventionResult. BUG=625063 Committed: https://crrev.com/e2f303eb3f571bd2e05de89de3aa08f15437e490 Cr-Commit-Position: refs/heads/master@{#403450}

Patch Set 1 #

Patch Set 2 : check encorce flag first #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M third_party/WebKit/Source/core/css/RemoteFontFaceSource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp View 1 6 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Takashi Toyoshima
Sakamoto-san, can you take a look?
4 years, 5 months ago (2016-06-30 11:10:45 UTC) #3
Kunihiko Sakamoto
lgtm
4 years, 5 months ago (2016-07-01 01:52:54 UTC) #4
Takashi Toyoshima
+kinuko for owner's approval.
4 years, 5 months ago (2016-07-01 06:22:51 UTC) #6
Takashi Toyoshima
BUG ID was updated with a new one so that I can merge this change ...
4 years, 5 months ago (2016-07-01 07:32:57 UTC) #8
kinuko
lgtm
4 years, 5 months ago (2016-07-01 08:42:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109353003/20001
4 years, 5 months ago (2016-07-01 12:27:18 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-01 14:16:40 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 14:19:03 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e2f303eb3f571bd2e05de89de3aa08f15437e490
Cr-Commit-Position: refs/heads/master@{#403450}

Powered by Google App Engine
This is Rietveld 408576698