Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2109343002: Fix a potential segfault in GpuVideoDecoder (Closed)

Created:
4 years, 5 months ago by watk
Modified:
4 years, 5 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a potential segfault in GpuVideoDecoder It's possible that NotifyError() is called between Initialize() and CompleteInitialization() which would previously result in a null pointer dereference. Now initialization is completed with an error. BUG=623740 Committed: https://crrev.com/3154c1f3d402698d8914e95348bca3d4062f3541 Cr-Commit-Position: refs/heads/master@{#403251}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M media/filters/gpu_video_decoder.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
sandersd (OOO until July 31)
4 years, 5 months ago (2016-06-30 19:20:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109343002/1
4 years, 5 months ago (2016-06-30 19:21:46 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-06-30 19:21:48 UTC) #7
sandersd (OOO until July 31)
lgtm
4 years, 5 months ago (2016-06-30 19:24:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109343002/1
4 years, 5 months ago (2016-06-30 19:24:57 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 19:30:22 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 19:30:38 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 19:32:28 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3154c1f3d402698d8914e95348bca3d4062f3541
Cr-Commit-Position: refs/heads/master@{#403251}

Powered by Google App Engine
This is Rietveld 408576698