Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Issue 210933002: Add target_arch=arm64 support. (Closed)

Created:
6 years, 9 months ago by rmcilroy
Modified:
6 years, 4 months ago
Reviewers:
Nico, Xianzhu
CC:
Primiano Tucci (use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git@master
Visibility:
Public.

Description

Add target_arch=arm64 support. Currently only adding jsimd_none.c to get things building. BUG=354405 R=wangxianzhu@chromium.org Committed: 259566

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M libjpeg.gyp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
rmcilroy
Xianzhu: Could you please review this CL. I'm not sure if I've uploaded it correctly ...
6 years, 9 months ago (2014-03-25 10:47:13 UTC) #1
Xianzhu
lgtm
6 years, 9 months ago (2014-03-25 15:57:10 UTC) #2
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 9 months ago (2014-03-25 16:13:32 UTC) #3
Sergey Berezin
The CQ bit was unchecked by sergeyberezin@chromium.org
6 years, 9 months ago (2014-03-25 23:22:18 UTC) #4
Sergey Berezin
On 2014/03/25 16:13:32, rmcilroy wrote: > The CQ bit was checked by mailto:rmcilroy@chromium.org The base ...
6 years, 9 months ago (2014-03-25 23:22:53 UTC) #5
rmcilroy
On 2014/03/25 23:22:53, Sergey Berezin wrote: > On 2014/03/25 16:13:32, rmcilroy wrote: > > The ...
6 years, 9 months ago (2014-03-26 12:26:24 UTC) #6
rmcilroy
Committed patchset #1 manually as r259566 (presubmit successful).
6 years, 9 months ago (2014-03-26 13:42:41 UTC) #7
Xianzhu
On 2014/03/26 13:42:41, rmcilroy wrote: > Committed patchset #1 manually as r259566 (presubmit successful). You've ...
6 years, 9 months ago (2014-03-26 14:49:01 UTC) #8
rmcilroy
On 2014/03/26 14:49:01, Xianzhu wrote: > On 2014/03/26 13:42:41, rmcilroy wrote: > > Committed patchset ...
6 years, 9 months ago (2014-03-26 15:02:18 UTC) #9
Nico
FYI: Upstream has a jsimd_arm_neon_64.S file – do you want to pull that in?
6 years, 4 months ago (2014-08-18 22:22:35 UTC) #10
rmcilroy
6 years, 4 months ago (2014-08-18 22:31:37 UTC) #11
Message was sent while issue was closed.
On 2014/08/18 22:22:35, Nico (very away) wrote:
> FYI: Upstream has a jsimd_arm_neon_64.S file – do you want to pull that
in?

We are looking into pulling this in however there seems to be a bug which is
causing rendering artifacts (see crbug.com/356100 #13 onwards).

Powered by Google App Engine
This is Rietveld 408576698