Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 2109303003: third_party: Update to version 8 of remote_shell_protocol (Closed)

Created:
4 years, 5 months ago by oshima
Modified:
4 years, 5 months ago
Reviewers:
reveman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

third_party: Update to version 8 of remote_shell_protocol * Add remote-shell interface to control system modality * Add shell-mode event to notify the shell mode switch * Shadow underlay should be deleted when shadow is turned off In new patch * updated system modal test in shell_surface_unittests to match new api. BUG=b/29625835, b/29229887 TBR=reveman@chromium.org Committed: https://crrev.com/8535a87186fc2359a8657a75c6694b605128e749 Cr-Commit-Position: refs/heads/master@{#403155}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -25 lines) Patch
M components/exo/shell_surface.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/exo/shell_surface.cc View 6 chunks +25 lines, -12 lines 0 comments Download
M components/exo/shell_surface_unittest.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M components/exo/wayland/server.cc View 5 chunks +26 lines, -2 lines 0 comments Download
M third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-client-protocol.h View 5 chunks +66 lines, -0 lines 0 comments Download
M third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-server-protocol.h View 5 chunks +52 lines, -0 lines 0 comments Download
M third_party/wayland-protocols/protocol/remote-shell-protocol.c View 3 chunks +7 lines, -4 lines 0 comments Download
M third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml View 4 chunks +36 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109303003/1
4 years, 5 months ago (2016-06-30 05:12:58 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 05:53:37 UTC) #5
oshima
This is reland of https://codereview.chromium.org/2104473002/. I forgot to update the test expectation. TBR'ing because the ...
4 years, 5 months ago (2016-06-30 12:39:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109303003/1
4 years, 5 months ago (2016-06-30 12:39:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 12:46:19 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 12:48:16 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8535a87186fc2359a8657a75c6694b605128e749
Cr-Commit-Position: refs/heads/master@{#403155}

Powered by Google App Engine
This is Rietveld 408576698