Add QuicStreamFactory as an observer of an SSLConfigService

Add QuicStreamFactory as an observer of an SSLConfigService

QuicStreamFactory implements SSLConfigService::Observer, but it never
was added as an observer to an SSLConfigService. Now
QuicStreamFactory::OnSSLConfigChanged will actually get called, and QUIC
streams will get torn down when the SSLConfig changes.

BUG=548423
Committed: https://crrev.com/642ae4ba1dc7b04a1d480d733cdced28de720e00
Cr-Commit-Position: refs/heads/master@{#403038}

[nharper, 2016-06-29 23:11:11]

nharper@chromium.org changed reviewers:
+ rch@chromium.org

[Ryan Hamilton, 2016-06-29 23:16:15]

lgtm

Thanks for doing this. Sorry for the screw up.

https://codereview.chromium.org/2109303002/diff/1/net/quic/quic_stream_factor...
File net/quic/quic_stream_factory.cc (right):

https://codereview.chromium.org/2109303002/diff/1/net/quic/quic_stream_factor...
net/quic/quic_stream_factory.cc:756: ssl_config_service_->RemoveObserver(this);
It'd sure be cool if we has some sort of ScopedObserver object that could be a
member of |this| which did AddObserver() when it was constructed and
RemoveObserver() when it was destroyed. But that's not something to do now.

https://codereview.chromium.org/2109303002/diff/1/net/quic/quic_stream_factor...
File net/quic/quic_stream_factory_test.cc (right):

https://codereview.chromium.org/2109303002/diff/1/net/quic/quic_stream_factor...
net/quic/quic_stream_factory_test.cc:2423:
ssl_config_service_->NotifySSLConfigChange();
Well, that was easy!

[nharper, 2016-06-29 23:18:59]

The CQ bit was checked by nharper@chromium.org

[commit-bot: I haz the power, 2016-06-29 23:20:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 00:40:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-30 00:40:54]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 00:42:07]

Description was changed from

==========
Add QuicStreamFactory as an observer of an SSLConfigService

QuicStreamFactory implements SSLConfigService::Observer, but it never
was added as an observer to an SSLConfigService. Now
QuicStreamFactory::OnSSLConfigChanged will actually get called, and QUIC
streams will get torn down when the SSLConfig changes.

BUG=548423
==========

to

==========
Add QuicStreamFactory as an observer of an SSLConfigService

QuicStreamFactory implements SSLConfigService::Observer, but it never
was added as an observer to an SSLConfigService. Now
QuicStreamFactory::OnSSLConfigChanged will actually get called, and QUIC
streams will get torn down when the SSLConfig changes.

BUG=548423

Committed: https://crrev.com/642ae4ba1dc7b04a1d480d733cdced28de720e00
Cr-Commit-Position: refs/heads/master@{#403038}
==========

[commit-bot: I haz the power, 2016-06-30 00:42:08]

Patchset 1 (id:??) landed as
https://crrev.com/642ae4ba1dc7b04a1d480d733cdced28de720e00
Cr-Commit-Position: refs/heads/master@{#403038}