Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: pkg/mdv/lib/mdv.dart

Issue 21093005: remove bindModel, the same effect can be achieved through createInstance (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/mdv/lib/mdv.dart
diff --git a/pkg/mdv/lib/mdv.dart b/pkg/mdv/lib/mdv.dart
index 8c465804ba72e0587686e099f78088446b424954..8ba6bf643507f1508c16be29eb2788227dd236ba 100644
--- a/pkg/mdv/lib/mdv.dart
+++ b/pkg/mdv/lib/mdv.dart
@@ -47,29 +47,15 @@ StreamController<DocumentFragment> _instanceCreated;
*/
// TODO(rafaelw): This is a hack, and is neccesary for the polyfill
// because custom elements are not upgraded during clone()
+// TODO(jmesserly): polymer removed this in:
+// https://github.com/Polymer/platform/commit/344ffeaae475babb529403f6608588a0fc73f4e7
Stream<DocumentFragment> get instanceCreated {
if (_instanceCreated == null) {
- _instanceCreated =
- new StreamController<DocumentFragment>(sync: true);
+ _instanceCreated = new StreamController<DocumentFragment>(sync: true);
}
return _instanceCreated.stream;
}
-/**
- * Binds all mustaches recursively starting from the [root] node.
- *
- * Note: this is not an official Model-Driven-Views API; it is intended to
- * support binding the [ShadowRoot]'s content to a model.
- */
-// TODO(jmesserly): this is needed to avoid two <template> nodes when using
-// bindings in a custom element's template. See also:
-// https://github.com/polymer-project/polymer/blob/master/src/bindMDV.js#L68
-// Called from:
-// https://github.com/polymer-project/polymer/blob/master/src/register.js#L99
-void bindModel(Node root, model, [BindingDelegate delegate]) {
- _addBindings(root, model, delegate);
-}
-
// TODO(jmesserly): investigate if expandos give us enough performance.
« no previous file with comments | « no previous file | pkg/mdv/test/template_element_test.dart » ('j') | tools/dom/templates/html/impl/impl_Element.darttemplate » ('J')

Powered by Google App Engine
This is Rietveld 408576698