Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2109293006: Added js and js_util to observatory deps (Closed)

Created:
4 years, 5 months ago by cbernaschina
Modified:
4 years, 5 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/pubspec.yaml View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
cbernaschina
4 years, 5 months ago (2016-06-30 19:35:33 UTC) #2
cbernaschina
Added turnidge & rmacnak as reviewer
4 years, 5 months ago (2016-06-30 20:56:35 UTC) #4
Cutch
lgtm
4 years, 5 months ago (2016-06-30 21:07:42 UTC) #5
cbernaschina
4 years, 5 months ago (2016-06-30 21:09:13 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
67063e3147f20e160608c1c0c36da374c7a99f74 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698