components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java - Issue 2109293005: [Cronet] Fix up log TAGs to be accurate and prevent future inaccuracies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

Issue 2109293005: [Cronet] Fix up log TAGs to be accurate and prevent future inaccuracies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: truncate ChromiumUrlRequestContext Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/api/src/org/chromium/net/JavaUrlRequest.java ('k') | components/cronet/android/java/src/org/chromium/net/CronetLibraryLoader.java » ('j') | components/cronet/android/java/src/org/chromium/net/CronetLibraryLoader.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

diff --git a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

index fdf9daf31139e05dab86e206ff801ae425679f77..2bd1b46cc7110f1d6a2343a9fb90cfb817cb45c4 100644

--- a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

+++ b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

@@ -23,7 +23,7 @@ public class ChromiumUrlRequestContext {

private static final int LOG_NONE = 3; // LOG(FATAL), no VLOG.

private static final int LOG_DEBUG = -1; // LOG(FATAL...INFO), VLOG(1)

private static final int LOG_VERBOSE = -2; // LOG(FATAL...INFO), VLOG(2)

- static final String LOG_TAG = "ChromiumNetwork";

+ static final String LOG_TAG = "ChromiumUrlRequestCont";

mef 2016/07/13 19:15:58 This is legacy api, should we leave it alone?

pauljensen 2016/08/17 11:58:33 I feel like we should fix it too. Until we remove

/**

* Native adapter object, owned by ChromiumUrlRequestContext.