Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2109293004: [gn] Switch basic linux32 bots to gn (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Switch basic linux32 bots to gn BUG=chromium:474921 Committed: https://crrev.com/27965f19a437a1111ba289fcdb98489a733f03e3 Cr-Commit-Position: refs/heads/master@{#37492}

Patch Set 1 #

Patch Set 2 : Fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -13 lines) Patch
M BUILD.gn View 2 chunks +7 lines, -0 lines 0 comments Download
M gni/isolate.gni View 2 chunks +7 lines, -1 line 0 comments Download
M gni/v8.gni View 1 chunk +3 lines, -0 lines 0 comments Download
M infra/mb/mb_config.pyl View 1 5 chunks +21 lines, -12 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109293004/1
4 years, 5 months ago (2016-06-30 15:09:10 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/18578)
4 years, 5 months ago (2016-06-30 15:13:41 UTC) #5
Michael Achenbach
PTAL Some links: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20builder/builds/17440/steps/compare%20build%20flags%20%28fyi%29/logs/stdio https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20builder/builds/14872/steps/compare%20build%20flags%20%28fyi%29/logs/stdio Things that caught my attention: In release in GN we ...
4 years, 5 months ago (2016-06-30 15:17:49 UTC) #7
vogelheim
On 2016/06/30 15:17:49, Michael Achenbach wrote: > PTAL > > Some links: > https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20builder/builds/17440/steps/compare%20build%20flags%20%28fyi%29/logs/stdio > ...
4 years, 5 months ago (2016-06-30 15:59:33 UTC) #8
vogelheim
lgtm
4 years, 5 months ago (2016-06-30 16:00:02 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109293004/20001
4 years, 5 months ago (2016-07-04 06:34:55 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/4348) v8_linux64_avx2_rel_ng_triggered on ...
4 years, 5 months ago (2016-07-04 06:53:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109293004/20001
4 years, 5 months ago (2016-07-04 07:36:52 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-04 07:52:13 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 07:54:42 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/27965f19a437a1111ba289fcdb98489a733f03e3
Cr-Commit-Position: refs/heads/master@{#37492}

Powered by Google App Engine
This is Rietveld 408576698