mash: Convert system tray network item to wm common types

mash: Convert system tray network item to wm common types

* Convert NetworkStateListDetailedView to wm common types and add debug name.
* Fix include guards.
* Move files to //ash/common/system/chromeos.
* Fix DEPS.

BUG=619636
TEST=ash_unittests, manual by opening the network (i) info panel and dumping
the window tree with Ctrl-Alt-Shift-W
TBR=derat@chromium.org

Committed: https://crrev.com/75c5a013d3d9c9bfd8874d754f65b75631f1b5b0
Cr-Commit-Position: refs/heads/master@{#403301}

[James Cook, 2016-06-29 23:25:25]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-06-29 23:25:26]

msw, please take a look. This eliminates the second-to-last reference to
ui/aura/window.h in ash/system (outside of test code).

[msw, 2016-06-30 17:41:12]

lgtm with a nit

https://codereview.chromium.org/2109293002/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/network/network_state_list_detailed_view.cc
(right):

https://codereview.chromium.org/2109293002/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/network/network_state_list_detailed_view.cc:152:
params->name = "NetworkStateListDetailedView";
nit: should this be "NetworkStateListDetailedView::InfoBubble"?

[James Cook, 2016-06-30 18:28:50]

Thanks for the review!

https://codereview.chromium.org/2109293002/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/network/network_state_list_detailed_view.cc
(right):

https://codereview.chromium.org/2109293002/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/network/network_state_list_detailed_view.cc:152:
params->name = "NetworkStateListDetailedView";
On 2016/06/30 17:41:12, msw wrote:
> nit: should this be "NetworkStateListDetailedView::InfoBubble"?

Done.

[James Cook, 2016-06-30 18:29:16]

jamescook@chromium.org changed reviewers:
+ derat@chromium.org

[James Cook, 2016-06-30 18:29:17]

TBR derat@ for moving an existing chromeos DEPS file from one place to another

[James Cook, 2016-06-30 18:29:22]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-06-30 18:29:22]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2109293002/#ps40001
(title: "tweak string")

[commit-bot: I haz the power, 2016-06-30 18:29:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 18:35:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 18:35:06]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Daniel Erat, 2016-06-30 19:30:07]

lgtm

[James Cook, 2016-06-30 21:35:51]

Description was changed from

==========
mash: Convert system tray network item to wm common types

* Convert NetworkStateListDetailedView to wm common types and add debug name.
* Fix include guards.
* Move files to //ash/common/system/chromeos.
* Fix DEPS.

BUG=619636
TEST=ash_unittests, manual by opening the network (i) info panel and dumping
the window tree with Ctrl-Alt-Shift-W
==========

to

==========
mash: Convert system tray network item to wm common types

* Convert NetworkStateListDetailedView to wm common types and add debug name.
* Fix include guards.
* Move files to //ash/common/system/chromeos.
* Fix DEPS.

BUG=619636
TEST=ash_unittests, manual by opening the network (i) info panel and dumping
the window tree with Ctrl-Alt-Shift-W
TBR=derat@chromium.org
==========

[James Cook, 2016-06-30 21:36:17]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-06-30 21:37:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 21:43:08]

Description was changed from

==========
mash: Convert system tray network item to wm common types

* Convert NetworkStateListDetailedView to wm common types and add debug name.
* Fix include guards.
* Move files to //ash/common/system/chromeos.
* Fix DEPS.

BUG=619636
TEST=ash_unittests, manual by opening the network (i) info panel and dumping
the window tree with Ctrl-Alt-Shift-W
TBR=derat@chromium.org
==========

to

==========
mash: Convert system tray network item to wm common types

* Convert NetworkStateListDetailedView to wm common types and add debug name.
* Fix include guards.
* Move files to //ash/common/system/chromeos.
* Fix DEPS.

BUG=619636
TEST=ash_unittests, manual by opening the network (i) info panel and dumping
the window tree with Ctrl-Alt-Shift-W
TBR=derat@chromium.org
==========

[commit-bot: I haz the power, 2016-06-30 21:43:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-30 21:43:23]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 21:44:45]

Description was changed from

==========
mash: Convert system tray network item to wm common types

* Convert NetworkStateListDetailedView to wm common types and add debug name.
* Fix include guards.
* Move files to //ash/common/system/chromeos.
* Fix DEPS.

BUG=619636
TEST=ash_unittests, manual by opening the network (i) info panel and dumping
the window tree with Ctrl-Alt-Shift-W
TBR=derat@chromium.org
==========

to

==========
mash: Convert system tray network item to wm common types

* Convert NetworkStateListDetailedView to wm common types and add debug name.
* Fix include guards.
* Move files to //ash/common/system/chromeos.
* Fix DEPS.

BUG=619636
TEST=ash_unittests, manual by opening the network (i) info panel and dumping
the window tree with Ctrl-Alt-Shift-W
TBR=derat@chromium.org

Committed: https://crrev.com/75c5a013d3d9c9bfd8874d754f65b75631f1b5b0
Cr-Commit-Position: refs/heads/master@{#403301}
==========

[commit-bot: I haz the power, 2016-06-30 21:44:46]

Patchset 3 (id:??) landed as
https://crrev.com/75c5a013d3d9c9bfd8874d754f65b75631f1b5b0
Cr-Commit-Position: refs/heads/master@{#403301}