Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2109253002: Allow git_cl to be called when no default server is given (Closed)

Created:
4 years, 5 months ago by martiniss
Modified:
4 years, 5 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, tandrii+omg_git_cl_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow git_cl to be called when no default server is given Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/6eda05f9e6a7d8a1454ff89915e21b4e59cd7140

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M git_cl.py View 2 chunks +14 lines, -7 lines 0 comments Download
M tests/git_cl_test.py View 2 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
martiniss
PTAL No idea if it's a good idea, but this is (sorta) needed to fix ...
4 years, 5 months ago (2016-06-29 22:06:49 UTC) #2
tandrii(chromium)
I like it. LGTM
4 years, 5 months ago (2016-06-30 14:02:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109253002/1
4 years, 5 months ago (2016-06-30 17:14:40 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 17:18:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/6eda05f9e6a7d8...

Powered by Google App Engine
This is Rietveld 408576698