Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issue 2109243003: Introduce --remote-debugging-frontend switch for custom remote debugging front-end (Closed)

Created:
4 years, 5 months ago by lushnikov
Modified:
4 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce --remote-debugging-frontend switch for custom remote debugging front-end DevTools "hosted mode" is broken in a multiple ways: - it uses sync XHR from inside the microtask (this was recentrly forbidden) - as the protocol was split and moved around, the InspectorBackendHostedMode.js is not able to generate proper inspector backend commands This patch introduces the --remote-debugging-frontend switch with a value of a absolute path to devtools front-end checkout. If the --remote-debugging-frontend switch is specified, then the remote debugging session will be opened with the front-end loaded from the specified endpoint. We assume that this endpoint will be serving a simple check-out of devtools front-end, which is missing generated files InspectorBackendCommands.js and SupportedCSSProperties.js. For this reason, requests to these files are fulfilled from the chrome devtools bundled resources. BUG=623602 R=dgozman

Patch Set 1 #

Patch Set 2 : move inspectorbackendcommands under gen #

Patch Set 3 : support absolute path instead of HTTP endpoint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -245 lines) Patch
M chrome/browser/devtools/frontend/devtools_discovery_page.html View 2 chunks +9 lines, -13 lines 0 comments Download
M chrome/browser/devtools/remote_debugging_server.cc View 1 2 3 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/devtools_ui.cc View 1 2 5 chunks +63 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/url_constants.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/inspector-backend-commands.html View 1 2 1 chunk +8 lines, -43 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/inspector-backend-commands-generation.html View 1 2 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/inspector-backend-commands-generation-expected.txt View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 1 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/devtools.gyp View 1 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/devtools.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js View 1 chunk +0 lines, -125 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/module.json View 1 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/CodeGeneratorFrontend.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (11 generated)
lushnikov
please, take a look
4 years, 5 months ago (2016-06-30 16:45:55 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109243003/20001
4 years, 5 months ago (2016-06-30 16:55:54 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/29511)
4 years, 5 months ago (2016-06-30 16:59:44 UTC) #11
lushnikov
please, take another look!
4 years, 5 months ago (2016-07-01 01:51:48 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109243003/40001
4 years, 5 months ago (2016-07-01 03:42:05 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/249020)
4 years, 5 months ago (2016-07-01 05:22:47 UTC) #17
pfeldman
This goes a bit backwards - instead of steering the app towards being a standalone ...
4 years, 5 months ago (2016-07-02 05:49:42 UTC) #18
lushnikov
True, unfortunately this patch doesn't help to achieve "stand-alone app" goal. However, it helps to ...
4 years, 5 months ago (2016-07-06 17:49:05 UTC) #19
pfeldman
On 2016/07/06 17:49:05, lushnikov wrote: > True, unfortunately this patch doesn't help to achieve "stand-alone ...
4 years, 5 months ago (2016-07-06 17:50:44 UTC) #20
lushnikov
4 years, 5 months ago (2016-07-06 18:15:31 UTC) #21
I see a few properties where they differentiate: end users, internal structure
and build setup.

The "standalone DevTools app" properties:
- users: all web developers
- internal structure: aim for speed, sources are concatenated/optimized
- build: any. It might be tedious to build (comparable to Chrome), but as far as
  there's a pre-build version and distribution channel it's fine.

The "hackable DevTools" properties:
- users: web developers who want to contribute to DevTools
- internal structure: aim for debuggability. Sources are not optimized
- build: minimal/none. Ideally, it is just a github checkout.

Powered by Google App Engine
This is Rietveld 408576698