Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2109213004: ARC: Add strings for opt-in related to location services (Closed)

Created:
4 years, 5 months ago by elijahtaylor1
Modified:
4 years, 5 months ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ARC: Add strings for opt-in related to location services BUG=b:29824233 Committed: https://crrev.com/34f025b2d8aee077676d046440fddd64818a2943 Cr-Commit-Position: refs/heads/master@{#403333}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
elijahtaylor1
PTAL this is a string only change for potential future use
4 years, 5 months ago (2016-06-30 05:40:07 UTC) #3
Yusuke Sato
lgtm
4 years, 5 months ago (2016-06-30 18:09:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109213004/20001
4 years, 5 months ago (2016-06-30 22:42:04 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-30 23:26:25 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 23:26:39 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 23:30:12 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/34f025b2d8aee077676d046440fddd64818a2943
Cr-Commit-Position: refs/heads/master@{#403333}

Powered by Google App Engine
This is Rietveld 408576698