Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2109133002: Fix script and compiler invocation when using non-default toolchain. (Closed)

Created:
4 years, 5 months ago by sdefresne
Modified:
4 years, 5 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@{0}
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix script and compiler invocation when using non-default toolchain. According to "gn help root_build_dir" the variable corresponds to the current directory when executing all compilers and scripts. So when building the command-line for compilers or scripts, "rebase_path" must use "root_build_dir" instead of "root_out_dir" otherwise they will break if building for non-default toolchain. BUG=603180 Committed: https://crrev.com/9b9b27be5e7007fb73ef6e0087e452227d92bbc6 Cr-Commit-Position: refs/heads/master@{#402825}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M build/config/ios/rules.gni View 4 chunks +6 lines, -4 lines 0 comments Download
M build/config/mac/base_rules.gni View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sdefresne
4 years, 5 months ago (2016-06-29 13:17:44 UTC) #2
sdefresne
Please take a look and send to CQ if LGTY.
4 years, 5 months ago (2016-06-29 13:17:50 UTC) #3
Robert Sesek
lgtm
4 years, 5 months ago (2016-06-29 15:29:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109133002/1
4 years, 5 months ago (2016-06-29 15:29:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 16:03:37 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 16:05:10 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b9b27be5e7007fb73ef6e0087e452227d92bbc6
Cr-Commit-Position: refs/heads/master@{#402825}

Powered by Google App Engine
This is Rietveld 408576698