Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2109093003: [wasm] Enable wasm frame inspection for debugging (Closed)

Created:
4 years, 5 months ago by titzer
Modified:
4 years, 5 months ago
Reviewers:
ahaas, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Enable wasm frame inspection for debugging This changes many interfaces to accept StandardFrames instead of JavaScriptFrames, and use the StackTraceFrameIterator instead of the JavaScriptFrameIterator. Also, the detailed frame information array now contains the script in addition to the function, as wasm frames are not associated to any javascript function. This is a rebase of (https://codereview.chromium.org/2069823003/), since clemensh's internship has ended. R=yangguo@chromium.org,ahaas@chromium.org BUG= Committed: https://crrev.com/2f8ed905827df3436a57759a7960ca64492af492 Cr-Commit-Position: refs/heads/master@{#37379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+449 lines, -153 lines) Patch
M src/debug/debug.cc View 5 chunks +30 lines, -21 lines 0 comments Download
M src/debug/debug-evaluate.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/debug/debug-frames.h View 3 chunks +14 lines, -7 lines 0 comments Download
M src/debug/debug-frames.cc View 8 chunks +37 lines, -23 lines 0 comments Download
M src/debug/debug-scopes.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/debug/debug-scopes.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M src/debug/mirrors.js View 4 chunks +26 lines, -13 lines 0 comments Download
M src/frames.h View 6 chunks +26 lines, -9 lines 0 comments Download
M src/frames.cc View 10 chunks +63 lines, -16 lines 0 comments Download
M src/frames-inl.h View 3 chunks +0 lines, -15 lines 0 comments Download
M src/isolate.h View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 11 chunks +93 lines, -27 lines 0 comments Download
M src/runtime/runtime-liveedit.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M src/wasm/wasm-debug.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/wasm/wasm-debug.cc View 3 chunks +41 lines, -1 line 0 comments Download
M src/wasm/wasm-module.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A test/mjsunit/wasm/frame-inspection.js View 1 chunk +74 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
titzer
4 years, 5 months ago (2016-06-29 09:25:52 UTC) #2
Yang
On 2016/06/29 09:25:52, titzer wrote: lgtm (rubberstamp)
4 years, 5 months ago (2016-06-29 09:29:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109093003/1
4 years, 5 months ago (2016-06-29 09:50:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 10:21:52 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 10:23:17 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f8ed905827df3436a57759a7960ca64492af492
Cr-Commit-Position: refs/heads/master@{#37379}

Powered by Google App Engine
This is Rietveld 408576698