ChromeOS: GetKeyboardLayoutsForResolvedLocale() should default to requested locale.

ChromeOS: GetKeyboardLayoutsForResolvedLocale() should default to requested locale.

When language is selected for public session, active keyboard should be selected
based on requested language variant, not resolved locale as it is now.
Also, we should merge the list of available keyboards from both
requested and resolved locales.

BUG=623882, 613185
TEST=Try to select language variant (for example, fr-CA) from the dropdown
on the public session POD. Keyboard should switch to fr-CA, and full list of
French keyboards should be available in the keyboard selector.

Committed: https://crrev.com/a291824c6fec494e432328577249d039aaaa1d2b
Cr-Commit-Position: refs/heads/master@{#403077}

[Alexander Alekseev, 2016-06-29 06:18:00]

alemate@chromium.org changed reviewers:
+ dzhioev@chromium.org

[Alexander Alekseev, 2016-06-29 06:18:01]

Please review.

[Alexander Alekseev, 2016-06-29 06:18:37]

alemate@chromium.org changed reviewers:
+ shuchen@chromium.org

[Alexander Alekseev, 2016-06-29 06:18:38]

dzhioev@, shuchen@ - please review.

[Alexander Alekseev, 2016-06-29 06:19:59]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-29 06:20:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 07:14:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 07:14:51]

Dry run: This issue passed the CQ dry run.

[Shu Chen, 2016-06-29 13:10:37]

https://codereview.chromium.org/2109063002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/l10n_util.cc (right):

https://codereview.chromium.org/2109063002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/l10n_util.cc:289:
std::vector<std::string>* layouts) {
Please remove potential duplicates in |layouts|.

https://codereview.chromium.org/2109063002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/l10n_util.cc:312: std::string selected;
|selected| is unused?

[Alexander Alekseev, 2016-06-29 23:00:46]

https://codereview.chromium.org/2109063002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/l10n_util.cc (right):

https://codereview.chromium.org/2109063002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/l10n_util.cc:289:
std::vector<std::string>* layouts) {
On 2016/06/29 13:10:37, Shu Chen wrote:
> Please remove potential duplicates in |layouts|.

Duplicates are removed on lines 318-327 below. We have
    std::set<std::string> input_methods_added;
specially for this.

https://codereview.chromium.org/2109063002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/l10n_util.cc:312: std::string selected;
On 2016/06/29 13:10:37, Shu Chen wrote:
> |selected| is unused?

See line 327 below.

[Shu Chen, 2016-06-30 02:26:08]

lgtm

[Alexander Alekseev, 2016-06-30 02:58:42]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2016-06-30 02:59:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 03:03:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-30 03:05:22]

Description was changed from

==========
ChromeOS: GetKeyboardLayoutsForResolvedLocale() should default to requested
locale.

When language is selected for public session, active keyboard should be selected
based on requested language variant, not resolved locale as it is now.
Also, we should merge the list of available keyboards from both
requested and resolved locales.

BUG=623882,613185
TEST=Try to select language variant (for example, fr-CA) from the dropdown
on the public session POD. Keyboard should switch to fr-CA, and full list of
French keyboards should be available in the keyboard selector.
==========

to

==========
ChromeOS: GetKeyboardLayoutsForResolvedLocale() should default to requested
locale.

When language is selected for public session, active keyboard should be selected
based on requested language variant, not resolved locale as it is now.
Also, we should merge the list of available keyboards from both
requested and resolved locales.

BUG=623882,613185
TEST=Try to select language variant (for example, fr-CA) from the dropdown
on the public session POD. Keyboard should switch to fr-CA, and full list of
French keyboards should be available in the keyboard selector.

Committed: https://crrev.com/a291824c6fec494e432328577249d039aaaa1d2b
Cr-Commit-Position: refs/heads/master@{#403077}
==========

[commit-bot: I haz the power, 2016-06-30 03:05:24]

Patchset 1 (id:??) landed as
https://crrev.com/a291824c6fec494e432328577249d039aaaa1d2b
Cr-Commit-Position: refs/heads/master@{#403077}