Implemented system tray UI for new account management.

ash/system/tray/hover_highlight_view.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/tray/hover_highlight_view.h"
 
 #include "ash/system/tray/fixed_sized_image_view.h"
 #include "ash/system/tray/tray_constants.h"
 #include "ash/system/tray/view_click_listener.h"
 #include "grit/ui_resources.h"
@@ skipping 47 matching lines @@
   text_label_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
   text_label_->SetFontList(text_label_->font_list().DeriveWithStyle(style));
   if (text_default_color_)
     text_label_->SetEnabledColor(text_default_color_);
   AddChildView(text_label_);
 
   SetAccessibleName(text);
 }
 
 views::Label* HoverHighlightView::AddLabel(const base::string16& text,
+                                           gfx::HorizontalAlignment alignment,
                                            gfx::Font::FontStyle style) {
   SetLayoutManager(new views::FillLayout());
   text_label_ = new views::Label(text);
-  int margin = kTrayPopupPaddingHorizontal +
-      kTrayPopupDetailsLabelExtraLeftMargin;
-  int left_margin = 0;
-  int right_margin = 0;
-  if (base::i18n::IsRTL())
-    right_margin = margin;
-  else
-    left_margin = margin;
+  int left_margin = kTrayPopupPaddingHorizontal;
+  int right_margin = kTrayPopupPaddingHorizontal;
+  if (alignment != gfx::ALIGN_CENTER) {

[Mr4D (OOO till 08-26), 2014/03/25 23:54:13]

Looking at this I think you imply which alignments are allowed. As such you
should document that in the header definition.

[dzhioev (left Google), 2014/03/26 13:29:22]

Actually any alignment is allowed now. There was problems with ALIGN_CENTER
before my changes were made. Margin were asymmetric, and if you set alignment of
text_label_ to ALIGN_CENTER it was shifted to the right. I made margin symmetric
for ALIGN_CENTER case.

[Mr4D (OOO till 08-26), 2014/03/26 16:49:53]

In that case: Shouldn't the two cases below then do different things for
ALIGN_LEFT / ALIGN_RIGHT?

[dzhioev (left Google), 2014/03/26 23:48:52]

For ALIGN_LEFT we add kTrayPopupDetailsLabelExtraLeftMargin to the left margin.
I don't know which behavior user will expect if he pass ALIGN_RIGHT here though
(nobody is using ALIGN_RIGHT now, and probably never will). I think we should
add extra padding to the left even for ALIGN_RIGHT.

+    if (base::i18n::IsRTL())
+      right_margin += kTrayPopupDetailsLabelExtraLeftMargin;
+    else
+      left_margin += kTrayPopupDetailsLabelExtraLeftMargin;
+  }
   text_label_->SetBorder(
       views::Border::CreateEmptyBorder(5, left_margin, 5, right_margin));
-  text_label_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+  text_label_->SetHorizontalAlignment(alignment);
   text_label_->SetFontList(text_label_->font_list().DeriveWithStyle(style));
   // Do not set alpha value in disable color. It will have issue with elide
   // blending filter in disabled state for rendering label text color.
   text_label_->SetDisabledColor(SkColorSetARGB(255, 127, 127, 127));
   if (text_default_color_)
     text_label_->SetEnabledColor(text_default_color_);
   AddChildView(text_label_);
 
   SetAccessibleName(text);
   return text_label_;
@@ skipping 21 matching lines @@
     text_label_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
     text_label_->SetFontList(text_label_->font_list().DeriveWithStyle(style));
     text_label_->SetDisabledColor(SkColorSetARGB(127, 0, 0, 0));
     if (text_default_color_)
       text_label_->SetEnabledColor(text_default_color_);
     AddChildView(text_label_);
 
     SetAccessibleName(text);
     return text_label_;
   }
-  return AddLabel(text, style);
+  return AddLabel(text, gfx::ALIGN_LEFT, style);
 }
 
 void HoverHighlightView::SetExpandable(bool expandable) {
   if (expandable != expandable_) {
     expandable_ = expandable;
     InvalidateLayout();
   }
 }
 
 bool HoverHighlightView::PerformAction(const ui::Event& event) {
@@ skipping 46 matching lines @@
   canvas->DrawColor(hover_ ? highlight_color_ : default_color_);
 }
 
 void HoverHighlightView::OnFocus() {
   ScrollRectToVisible(gfx::Rect(gfx::Point(), size()));
   ActionableView::OnFocus();
 }
 
 }  // namespace internal
 }  // namespace ash