Convert video-controls* tests to testharness.js

Convert video-controls* tests to testharness.js

Cleaning up video-controls* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
Committed: https://crrev.com/4d81c69ab2290803a45c6e53efef3649809b1daa
Cr-Commit-Position: refs/heads/master@{#403142}

[Srirama, 2016-06-29 19:31:55]

Description was changed from

==========
fix


fix

BUG=
==========

to

==========
Convert video-controls* tests to testharness.js

Cleaning up video-controls* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[Srirama, 2016-06-29 19:35:45]

srirama.m@samsung.com changed reviewers:
+ foolip@chromium.org, fs@opera.com

[Srirama, 2016-06-29 19:35:46]

PTAL

https://codereview.chromium.org/2108993003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/video-controls-auto-hide-after-play-by-touch.html
(left):

https://codereview.chromium.org/2108993003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-controls-auto-hide-after-play-by-touch.html:41:
dispatchActivateEvent(controls);
do we need this? the test passes even without this.

[fs, 2016-06-29 21:15:01]

lgtm

https://codereview.chromium.org/2108993003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/video-controls-always-visible-when-control-hovered.html
(right):

https://codereview.chromium.org/2108993003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-controls-always-visible-when-control-hovered.html:7:
<video controls></video>
I think the reason this had 'loop', was to avoid ending up in the 'ended' state
(where controls will always show IIRC.)

https://codereview.chromium.org/2108993003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/video-controls-attribute-fullscreen.html
(right):

https://codereview.chromium.org/2108993003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-controls-attribute-fullscreen.html:22:
})
Nit: ;

https://codereview.chromium.org/2108993003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/video-controls-auto-hide-after-play-by-touch.html
(left):

https://codereview.chromium.org/2108993003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-controls-auto-hide-after-play-by-touch.html:41:
dispatchActivateEvent(controls);
On 2016/06/29 at 19:35:45, Srirama wrote:
> do we need this? the test passes even without this.

Off hand I can't think of any reason for why it would be needed either. If
digging in history doesn't reveal anything though, it might be better to keep it
around (it may well be that it had an adverse effect on the test...)

https://codereview.chromium.org/2108993003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/video-controls-auto-hide-after-play-by-touch.html
(right):

https://codereview.chromium.org/2108993003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-controls-auto-hide-after-play-by-touch.html:7:
<video controls></video>
I think 'loop' was here for the same reason as above.

[Srirama, 2016-06-30 09:34:27]

https://codereview.chromium.org/2108993003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/video-controls-always-visible-when-control-hovered.html
(right):

https://codereview.chromium.org/2108993003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-controls-always-visible-when-control-hovered.html:7:
<video controls></video>
On 2016/06/29 21:15:01, fs wrote:
> I think the reason this had 'loop', was to avoid ending up in the 'ended'
state
> (where controls will always show IIRC.)

Done. The video duration is 6sec and controls timeout value is 3sec, so i
thought it is good enough to finish the test without looping. Anyway no harm in
keeping it though, so adding loop again.

https://codereview.chromium.org/2108993003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/video-controls-attribute-fullscreen.html
(right):

https://codereview.chromium.org/2108993003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-controls-attribute-fullscreen.html:22:
})
On 2016/06/29 21:15:01, fs wrote:
> Nit: ;

Done.

https://codereview.chromium.org/2108993003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/video-controls-auto-hide-after-play-by-touch.html
(left):

https://codereview.chromium.org/2108993003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-controls-auto-hide-after-play-by-touch.html:41:
dispatchActivateEvent(controls);
On 2016/06/29 21:15:01, fs wrote:
> On 2016/06/29 at 19:35:45, Srirama wrote:
> > do we need this? the test passes even without this.
> 
> Off hand I can't think of any reason for why it would be needed either. If
> digging in history doesn't reveal anything though, it might be better to keep
it
> around (it may well be that it had an adverse effect on the test...)

I will keep it to be on safe side.

https://codereview.chromium.org/2108993003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/video-controls-auto-hide-after-play-by-touch.html
(right):

https://codereview.chromium.org/2108993003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-controls-auto-hide-after-play-by-touch.html:7:
<video controls></video>
On 2016/06/29 21:15:01, fs wrote:
> I think 'loop' was here for the same reason as above.

Done.

[Srirama, 2016-06-30 09:35:45]

The CQ bit was checked by srirama.m@samsung.com

[Srirama, 2016-06-30 09:35:46]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2108993003/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2016-06-30 09:36:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 11:51:59]

Description was changed from

==========
Convert video-controls* tests to testharness.js

Cleaning up video-controls* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert video-controls* tests to testharness.js

Cleaning up video-controls* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[commit-bot: I haz the power, 2016-06-30 11:52:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-30 11:55:30]

Description was changed from

==========
Convert video-controls* tests to testharness.js

Cleaning up video-controls* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert video-controls* tests to testharness.js

Cleaning up video-controls* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Committed: https://crrev.com/4d81c69ab2290803a45c6e53efef3649809b1daa
Cr-Commit-Position: refs/heads/master@{#403142}
==========

[commit-bot: I haz the power, 2016-06-30 11:55:31]

Patchset 2 (id:??) landed as
https://crrev.com/4d81c69ab2290803a45c6e53efef3649809b1daa
Cr-Commit-Position: refs/heads/master@{#403142}