Reorder browser list on workspace switch

chrome/browser/ui/views/frame/browser_frame.cc

Index: chrome/browser/ui/views/frame/browser_frame.cc
diff --git a/chrome/browser/ui/views/frame/browser_frame.cc b/chrome/browser/ui/views/frame/browser_frame.cc
index d1c767c688ff48a42b58792dd2922f17db57f6a5..7e3accec22669ad243f817e384155ba329233730 100644
--- a/chrome/browser/ui/views/frame/browser_frame.cc
+++ b/chrome/browser/ui/views/frame/browser_frame.cc
@@ -220,7 +220,9 @@ void BrowserFrame::OnNativeWidgetActivationChanged(bool active) {
 }
 
 void BrowserFrame::OnNativeWidgetWorkspaceChanged() {
-  chrome::SaveWindowWorkspace(browser_view_->browser(), GetWorkspace());
+  Browser* browser = browser_view_->browser();
+  chrome::SaveWindowWorkspace(browser, GetWorkspace());
+  BrowserList::SetLastActive(browser);

[sky, 2016/07/06 20:33:05]

Might browser not be active at this point?

[Tom (Use chromium acct), 2016/07/06 22:29:16]

It might not be.  In cinnamon, you can "zoom-out" to see all workspaces, move a
window from a different workspace into the current workspace (without activating
it), and then zoom-in back to your workspace.  We don't get a workspace change
event in this case.

Although you made me realize this code is wrong.  We may move a browser to a
workspace other than the current one.  In this case, we don't want the browser
to be SetLastActive.  Even if we do move it to the current workspace, we want it
to be below the active one.

So I guess the correct thing to do is call
BrowserList::ReorderAfterWorkspaceChange, but we have no way of giving it the
current workspace now that display::Desktop is gone.

[sky, 2016/07/07 03:23:27]

An ifdef for linux and calling to x11desktop to get the workspace is fine here.

[Tom (Use chromium acct), 2016/07/07 19:12:10]

Done.

   Widget::OnNativeWidgetWorkspaceChanged();
 }