Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: components/policy/core/common/remote_commands/remote_commands_service.cc

Issue 2108873004: Add logging of remote command invalidations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add todos and extra log Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/remote_commands/remote_commands_service.cc
diff --git a/components/policy/core/common/remote_commands/remote_commands_service.cc b/components/policy/core/common/remote_commands/remote_commands_service.cc
index 738c1b85adf6e60558ac611cf7594f22b0d23327..8e2874685b721db21ee6bafb501dd2be4bcb740c 100644
--- a/components/policy/core/common/remote_commands/remote_commands_service.cc
+++ b/components/policy/core/common/remote_commands/remote_commands_service.cc
@@ -32,10 +32,16 @@ RemoteCommandsService::~RemoteCommandsService() {
}
bool RemoteCommandsService::FetchRemoteCommands() {
- if (!client_->is_registered())
+ // TODO(hunyadym): Remove after b/28068258 is fixed.
+ CHROMEOS_SYSLOG(WARNING) << "Fetching remote commands.";
+ if (!client_->is_registered()) {
+ CHROMEOS_SYSLOG(WARNING) << "Client is not registered.";
return false;
+ }
if (command_fetch_in_progress_) {
+ // TODO(hunyadym): Remove after b/28068258 is fixed.
+ CHROMEOS_SYSLOG(WARNING) << "Command fetch is already in progress.";
has_enqueued_fetch_request_ = true;
return false;
}
@@ -151,6 +157,8 @@ void RemoteCommandsService::OnRemoteCommandsFetched(
DeviceManagementStatus status,
const std::vector<enterprise_management::RemoteCommand>& commands) {
DCHECK(command_fetch_in_progress_);
+ // TODO(hunyadym): Remove after b/28068258 is fixed.
+ CHROMEOS_SYSLOG(WARNING) << "Remote commands fetched.";
command_fetch_in_progress_ = false;
// TODO(binjin): Add retrying on errors. See http://crbug.com/466572.

Powered by Google App Engine
This is Rietveld 408576698