Add logging of remote command invalidations.

Add logging of remote command invalidations.

BUG=619741
Committed: https://crrev.com/10e9c2815e16885596c7a183950d6680d1d33358
Cr-Commit-Position: refs/heads/master@{#403157}

[Marton Hunyady, 2016-06-29 12:45:48]

hunyadym@chromium.org changed reviewers:
+ atwilson@chromium.org

[Marton Hunyady, 2016-06-29 13:43:40]

hunyadym@chromium.org changed reviewers:
+ jinzhang@chromium.org

[Andrew T Wilson (Slow), 2016-06-29 15:35:35]

lgtm, pending adding TODO() statements.

https://codereview.chromium.org/2108873004/diff/1/chrome/browser/policy/cloud...
File chrome/browser/policy/cloud/remote_commands_invalidator.cc (right):

https://codereview.chromium.org/2108873004/diff/1/chrome/browser/policy/cloud...
chrome/browser/policy/cloud/remote_commands_invalidator.cc:31:
CHROMEOS_SYSLOG(WARNING) << "Initialize RemoteCommandsInvalidator.";
I think these are all intended to be temporary logs, so we should probably add
"// TODO(hunyadym): Remove after crbug.com/123456 is fixed" to these.

[jinzhang1, 2016-06-29 16:46:59]

The CQ bit was checked by jinzhang@chromium.org

[jinzhang1, 2016-06-29 16:47:00]

The CQ bit was unchecked by jinzhang@chromium.org

[jinzhang1, 2016-06-29 16:47:56]

https://codereview.chromium.org/2108873004/diff/1/chrome/browser/policy/cloud...
File chrome/browser/policy/cloud/remote_commands_invalidator.cc (right):

https://codereview.chromium.org/2108873004/diff/1/chrome/browser/policy/cloud...
chrome/browser/policy/cloud/remote_commands_invalidator.cc:104:
it.Acknowledge();
Can we add a log statement here to make sure "DoRemoteCommandsFetch()" will be
executed?

[Marton Hunyady, 2016-06-30 08:45:54]

https://codereview.chromium.org/2108873004/diff/1/chrome/browser/policy/cloud...
File chrome/browser/policy/cloud/remote_commands_invalidator.cc (right):

https://codereview.chromium.org/2108873004/diff/1/chrome/browser/policy/cloud...
chrome/browser/policy/cloud/remote_commands_invalidator.cc:31:
CHROMEOS_SYSLOG(WARNING) << "Initialize RemoteCommandsInvalidator.";
On 2016/06/29 15:35:35, Andrew T Wilson (Slow) wrote:
> I think these are all intended to be temporary logs, so we should probably add
> "// TODO(hunyadym): Remove after crbug.com/123456 is fixed" to these.

Done.

https://codereview.chromium.org/2108873004/diff/1/chrome/browser/policy/cloud...
chrome/browser/policy/cloud/remote_commands_invalidator.cc:104:
it.Acknowledge();
On 2016/06/29 16:47:56, jinzhang1 wrote:
> Can we add a log statement here to make sure "DoRemoteCommandsFetch()" will be
> executed?

Done.

[Andrew T Wilson (Slow), 2016-06-30 11:54:05]

https://codereview.chromium.org/2108873004/diff/20001/chrome/browser/policy/c...
File chrome/browser/policy/cloud/remote_commands_invalidator.cc (right):

https://codereview.chromium.org/2108873004/diff/20001/chrome/browser/policy/c...
chrome/browser/policy/cloud/remote_commands_invalidator.cc:31: //
TODO(hunyadym): Remove after b/28068258 is fixed.
Let's make this a crbug instead - even if you have to log a new one.

[Marton Hunyady, 2016-06-30 11:59:09]

https://codereview.chromium.org/2108873004/diff/20001/chrome/browser/policy/c...
File chrome/browser/policy/cloud/remote_commands_invalidator.cc (right):

https://codereview.chromium.org/2108873004/diff/20001/chrome/browser/policy/c...
chrome/browser/policy/cloud/remote_commands_invalidator.cc:31: //
TODO(hunyadym): Remove after b/28068258 is fixed.
On 2016/06/30 11:54:04, Andrew T Wilson (Slow) wrote:
> Let's make this a crbug instead - even if you have to log a new one.

Done.

[Marton Hunyady, 2016-06-30 11:59:33]

The CQ bit was checked by hunyadym@chromium.org

[Marton Hunyady, 2016-06-30 11:59:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
atwilson@chromium.org
Link to the patchset: https://codereview.chromium.org/2108873004/#ps40001
(title: "Replace b with crbug")

[commit-bot: I haz the power, 2016-06-30 11:59:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 12:51:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-30 12:51:50]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 12:53:41]

Description was changed from

==========
Add logging of remote command invalidations.

BUG=619741
==========

to

==========
Add logging of remote command invalidations.

BUG=619741

Committed: https://crrev.com/10e9c2815e16885596c7a183950d6680d1d33358
Cr-Commit-Position: refs/heads/master@{#403157}
==========

[commit-bot: I haz the power, 2016-06-30 12:53:43]

Patchset 3 (id:??) landed as
https://crrev.com/10e9c2815e16885596c7a183950d6680d1d33358
Cr-Commit-Position: refs/heads/master@{#403157}