Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2108873003: Fix vulkan onGetWritePixelsInfo (Closed)

Created:
4 years, 5 months ago by egdaniel
Modified:
4 years, 5 months ago
Reviewers:
jvanverth1, Brian Osman
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix vulkan onGetWritePixelsInfo When the configs are the same in Vulkan we know we can do write pixels, but the caller may need to do a draw, so make sure we set up the tempDrawInfo before returning. BUG=skia:5461, skia:5458 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108873003 Committed: https://skia.googlesource.com/skia/+/d66110f5972169dbcda8932c3a9a001adff23df4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/gpu/vk/GrVkGpu.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
egdaniel
4 years, 5 months ago (2016-06-28 20:18:47 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108873003/1
4 years, 5 months ago (2016-06-28 20:20:29 UTC) #5
jvanverth1
lgtm
4 years, 5 months ago (2016-06-28 20:22:17 UTC) #6
Brian Osman
lgtm
4 years, 5 months ago (2016-06-28 20:23:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108873003/1
4 years, 5 months ago (2016-06-28 20:25:51 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 20:38:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d66110f5972169dbcda8932c3a9a001adff23df4

Powered by Google App Engine
This is Rietveld 408576698