Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2108863004: MD Settings: move appeal into flow to unhide Advanced toggle (Closed)

Created:
4 years, 5 months ago by Dan Beam
Modified:
4 years, 5 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: move appeal into flow to unhide Advanced toggle R=dpapad@chromium.org BUG=619715 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/677d4cfc7b78c8286a9b278914804f5e26209e3d Cr-Commit-Position: refs/heads/master@{#402682}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -57 lines) Patch
M chrome/browser/resources/settings/settings.html View 1 chunk +0 lines, -43 lines 0 comments Download
M chrome/browser/resources/settings/settings.js View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.html View 3 chunks +40 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.js View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Dan Beam
4 years, 5 months ago (2016-06-28 22:24:46 UTC) #2
dpapad
LGTM Optional (and arguable) suggestion: Probably it would be an overkill at this point since ...
4 years, 5 months ago (2016-06-28 22:31:19 UTC) #3
Dan Beam
On 2016/06/28 22:31:19, dpapad wrote: > LGTM > > Optional (and arguable) suggestion: Probably it ...
4 years, 5 months ago (2016-06-28 23:57:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108863004/1
4 years, 5 months ago (2016-06-28 23:59:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 02:36:47 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 02:38:33 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/677d4cfc7b78c8286a9b278914804f5e26209e3d
Cr-Commit-Position: refs/heads/master@{#402682}

Powered by Google App Engine
This is Rietveld 408576698