Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2108863003: Revert of Close the panel if show has been requested (Closed)

Created:
4 years, 5 months ago by mdjones
Modified:
4 years, 5 months ago
Reviewers:
Theresa
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Close the panel if show has been requested (patchset #1 id:1 of https://codereview.chromium.org/2097623003/ ) Reason for revert: This patch does not entirely fix the issue since a panel can be opened by the panel manager without being requested. Original issue's description: > Close the panel if show has been requested > > When a panel is requested to show, it may not be visible yet and > isShowing will return false. If two panels try to show simultaneously > this can cause the incorrect panel to appear. This change keeps track > of whether peek has been called so there can be a corresponding close > call, regardless of panel visibility. > > BUG=623017 > > Committed: https://crrev.com/967e335bb9ad405a0e13d7827d3cc1875d819914 > Cr-Commit-Position: refs/heads/master@{#402218} TBR=twellington@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=623017 Committed: https://crrev.com/be33b3d55fa4ab89f4e4a787b1c704ac1c286aa0 Cr-Commit-Position: refs/heads/master@{#402576}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java View 3 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mdjones
Created Revert of Close the panel if show has been requested
4 years, 5 months ago (2016-06-28 20:57:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108863003/1
4 years, 5 months ago (2016-06-28 20:59:02 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 22:40:02 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 22:44:26 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be33b3d55fa4ab89f4e4a787b1c704ac1c286aa0
Cr-Commit-Position: refs/heads/master@{#402576}

Powered by Google App Engine
This is Rietveld 408576698