Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3225)

Unified Diff: apps/app_load_service.cc

Issue 2108853002: Restrict use of two app-launching command line flags (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a browsertest Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « apps/DEPS ('k') | apps/load_and_launch_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apps/app_load_service.cc
diff --git a/apps/app_load_service.cc b/apps/app_load_service.cc
index eb4b5c6b1c5e7231fe7bd59986da09a0b808b3c0..bf04d2d73649d7b4a87a95de22692bcc72a1d7b3 100644
--- a/apps/app_load_service.cc
+++ b/apps/app_load_service.cc
@@ -64,8 +64,9 @@ bool AppLoadService::LoadAndLaunch(const base::FilePath& extension_path,
ExtensionService* extension_service =
ExtensionSystem::Get(profile_)->extension_service();
std::string extension_id;
- if (!extensions::UnpackedInstaller::Create(extension_service)->
- LoadFromCommandLine(base::FilePath(extension_path), &extension_id)) {
+ if (!extensions::UnpackedInstaller::Create(extension_service)
+ ->LoadFromCommandLine(base::FilePath(extension_path), &extension_id,
+ true)) {
return false;
}
@@ -81,8 +82,9 @@ bool AppLoadService::Load(const base::FilePath& extension_path) {
ExtensionService* extension_service =
ExtensionSystem::Get(profile_)->extension_service();
std::string extension_id;
- return extensions::UnpackedInstaller::Create(extension_service)->
- LoadFromCommandLine(base::FilePath(extension_path), &extension_id);
+ return extensions::UnpackedInstaller::Create(extension_service)
+ ->LoadFromCommandLine(base::FilePath(extension_path), &extension_id,
+ true);
asargent_no_longer_on_chrome 2016/07/20 21:33:32 optional: sometimes it can aid readability to eith
proberge 2016/07/21 14:59:43 Done.
}
// static
« no previous file with comments | « apps/DEPS ('k') | apps/load_and_launch_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698