Issue 2108843002: kiosk: Fix OobeScreenWaiter get wrong current screen

Issue 2108843002: kiosk: Fix OobeScreenWaiter get wrong current screen (Closed)

Created:
4 years, 5 months ago by xiyuan

Modified:
4 years, 5 months ago

Reviewers:
jennyz

CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

kiosk: Fix OobeScreenWaiter get wrong current screen The real test flakyness on splash screen wait time out should be fixed with https://codereview.chromium.org/2107353002/ BUG=618326 Committed: https://crrev.com/5d8335a1118427d7a496cdf976433dd92169bcf1 Cr-Commit-Position: refs/heads/master@{#403508}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -10 lines)			Patch
	M	chrome/browser/chromeos/login/kiosk_browsertest.cc	View		1 chunk	+1 line, -9 lines	0 comments	Download
	M	chrome/browser/ui/webui/chromeos/login/oobe_ui.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 15 (8 generated)

xiyuan

https://codereview.chromium.org/2107353002/ is the right fix. Abandon this.

4 years, 5 months ago (2016-07-01 15:32:55 UTC) #4

xiyuan

On 2016/07/01 15:32:55, xiyuan wrote: > https://codereview.chromium.org/2107353002/ is the right fix. Abandon this. Abandoning too ...

4 years, 5 months ago (2016-07-01 15:39:05 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108843002/1

4 years, 5 months ago (2016-07-01 19:11:02 UTC) #11

commit-bot: I haz the power

4 years, 5 months ago (2016-07-01 20:10:42 UTC) #15

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5d8335a1118427d7a496cdf976433dd92169bcf1
Cr-Commit-Position: refs/heads/master@{#403508}