Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1534)

Unified Diff: chrome/browser/io_thread.cc

Issue 2108833005: Adds domain names for all qualified CT logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Slightly more documentation about DNS endpoints for logs Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/chrome_switches.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/io_thread.cc
diff --git a/chrome/browser/io_thread.cc b/chrome/browser/io_thread.cc
index 33ee5ea477189541f948c661759b870ebd8cdca1..b25829b2206f5bd1f3b6562de8c06ecbfa83350b 100644
--- a/chrome/browser/io_thread.cc
+++ b/chrome/browser/io_thread.cc
@@ -548,15 +548,18 @@ void IOThread::Init() {
curr_log, ":", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
CHECK_GE(log_metadata.size(), 3u)
<< "CT log metadata missing: Switch format is "
- << "'description:base64_key:url_without_schema'.";
+ << "'description:base64_key:url_without_schema[:dns_domain]'.";
std::string log_description(log_metadata[0]);
std::string log_url(std::string("https://") + log_metadata[2]);
+ std::string log_dns_domain;
+ if (log_metadata.size() >= 4)
+ log_dns_domain = log_metadata[3];
std::string ct_public_key_data;
CHECK(base::Base64Decode(log_metadata[1], &ct_public_key_data))
<< "Unable to decode CT public key.";
scoped_refptr<const net::CTLogVerifier> external_log_verifier(
net::CTLogVerifier::Create(ct_public_key_data, log_description,
- log_url));
+ log_url, log_dns_domain));
CHECK(external_log_verifier) << "Unable to parse CT public key.";
VLOG(1) << "Adding log with description " << log_description;
ct_logs.push_back(external_log_verifier);
« no previous file with comments | « no previous file | chrome/common/chrome_switches.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698