net/cert/multi_log_ct_verifier_unittest.cc - Issue 2108833005: Adds domain names for all qualified CT logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/multi_log_ct_verifier_unittest.cc

Issue 2108833005: Adds domain names for all qualified CT logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make dns_domain a required parameter of CtLogVerifier::Create Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/multi_log_ct_verifier_unittest.cc

diff --git a/net/cert/multi_log_ct_verifier_unittest.cc b/net/cert/multi_log_ct_verifier_unittest.cc

index 36dbdc697d102f05dadfa150be50128a4159b82c..797b6b02024478dd0f968c3c497c3a00e24ee87f 100644

--- a/net/cert/multi_log_ct_verifier_unittest.cc

+++ b/net/cert/multi_log_ct_verifier_unittest.cc

@@ -51,8 +51,9 @@ class MockSCTObserver : public CTVerifier::Observer {

class MultiLogCTVerifierTest : public ::testing::Test {

public:

void SetUp() override {

- scoped_refptr<const CTLogVerifier> log(CTLogVerifier::Create(

- ct::GetTestPublicKey(), kLogDescription, "https://ct.example.com"));

+ scoped_refptr<const CTLogVerifier> log(

+ CTLogVerifier::Create(ct::GetTestPublicKey(), kLogDescription,

+ "https://ct.example.com", nullptr));

ASSERT_TRUE(log);

log_verifiers_.push_back(log);