Adds domain names for all qualified CT logs

net/cert/ct_log_verifier.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_CERT_CT_LOG_VERIFIER_H_
 #define NET_CERT_CT_LOG_VERIFIER_H_
 
 #include <string>
 
 #include "base/gtest_prod_util.h"
@@ skipping 22 matching lines @@
 // Tree Head (STH) signatures.
 // Immutable: Does not hold any state beyond the log information it was
 // initialized with.
 class NET_EXPORT CTLogVerifier
     : public base::RefCountedThreadSafe<CTLogVerifier> {
  public:
   // Creates a new CTLogVerifier that will verify SignedCertificateTimestamps
   // using |public_key|, which is a DER-encoded SubjectPublicKeyInfo.
   // If |public_key| refers to an unsupported public key, returns NULL.
   // |description| is a textual description of the log.
+  // |url| is the URL of the log's HTTPS API endpoint.
+  // |domain| is the DNS name of the log's DNS API endpoint, if one exists.

[Eran Messeri, 2016/06/30 20:02:51]

rename |domain|  to |dns_domain| throughout so it's explicit this is the domain
for contacting the log via DNS.

[Rob Percival, 2016/07/08 09:45:42]

Done.

   static scoped_refptr<const CTLogVerifier> Create(
       const base::StringPiece& public_key,
       const base::StringPiece& description,
-      const base::StringPiece& url);
+      const base::StringPiece& url,
+      const base::StringPiece& domain = nullptr);
 
   // Returns the log's key ID (RFC6962, Section 3.2)
   const std::string& key_id() const { return key_id_; }
   // Returns the log's human-readable description.
   const std::string& description() const { return description_; }
   // Returns the log's URL
   const GURL& url() const { return url_; }
 
+  // Returns the log's domain (for CT over DNS queries).

[Eran Messeri, 2016/06/30 20:02:51]

Nit: Link to the CT-over-DNS protocol documentation

[Rob Percival, 2016/07/08 09:45:42]

Done.

+  // This will be empty if the log has no DNS API endpoint.
+  const std::string& domain() const { return domain_; }
+
   // Verifies that |sct| is valid for |entry| and was signed by this log.
   bool Verify(const ct::LogEntry& entry,
               const ct::SignedCertificateTimestamp& sct) const;
 
   // Verifies that |signed_tree_head| is a valid Signed Tree Head (RFC 6962,
   // Section 3.5) for this log.
   bool VerifySignedTreeHead(const ct::SignedTreeHead& signed_tree_head) const;
 
   // Verifies that |proof| is a valid consistency proof (RFC 6962, Section
   // 2.1.2) for this log, and which proves that |old_tree_hash| has
   // been fully incorporated into the Merkle tree represented by
   // |new_tree_hash|.
   bool VerifyConsistencyProof(const ct::MerkleConsistencyProof& proof,
                               const std::string& old_tree_hash,
                               const std::string& new_tree_hash) const;
 
  private:
   FRIEND_TEST_ALL_PREFIXES(CTLogVerifierTest, VerifySignature);
   friend class base::RefCountedThreadSafe<CTLogVerifier>;
 
-  CTLogVerifier(const base::StringPiece& description, const GURL& url);
+  CTLogVerifier(const base::StringPiece& description,
+                const GURL& url,
+                const base::StringPiece& domain);
   ~CTLogVerifier();
 
   // Performs crypto-library specific initialization.
   bool Init(const base::StringPiece& public_key);
 
   // Performs the underlying verification using the selected public key. Note
   // that |signature| contains the raw signature data (eg: without any
   // DigitallySigned struct encoding).
   bool VerifySignature(const base::StringPiece& data_to_sign,
                        const base::StringPiece& signature) const;
 
   // Returns true if the signature and hash algorithms in |signature|
   // match those of the log
   bool SignatureParametersMatch(const ct::DigitallySigned& signature) const;
 
   std::string key_id_;
   std::string description_;
   GURL url_;
+  std::string domain_;

[Eran Messeri, 2016/06/30 20:02:51]

As mentioned above, dns_domain_.

[Rob Percival, 2016/07/08 09:45:42]

Done.

   ct::DigitallySigned::HashAlgorithm hash_algorithm_;
   ct::DigitallySigned::SignatureAlgorithm signature_algorithm_;
 
   EVP_PKEY* public_key_;
 };
 
 }  // namespace net
 
 #endif  // NET_CERT_CT_LOG_VERIFIER_H_