Adds domain names for all qualified CT logs

net/quic/crypto/proof_verifier_chromium_test.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/crypto/proof_verifier_chromium.h"
 
 #include "base/memory/ref_counted.h"
 #include "net/base/net_errors.h"
 #include "net/cert/cert_status_flags.h"
 #include "net/cert/cert_verifier.h"
@@ skipping 100 matching lines @@
                                                        BoundNetLog())) {}
 
   void SetUp() override {
     EXPECT_CALL(ct_policy_enforcer_, DoesConformToCertPolicy(_, _, _))
         .WillRepeatedly(
             Return(ct::CertPolicyCompliance::CERT_POLICY_NOT_ENOUGH_SCTS));
     EXPECT_CALL(ct_policy_enforcer_, DoesConformToCTEVPolicy(_, _, _, _))
         .WillRepeatedly(
             Return(ct::EVPolicyCompliance::EV_POLICY_DOES_NOT_APPLY));
 
-    scoped_refptr<const CTLogVerifier> log(CTLogVerifier::Create(
-        ct::GetTestPublicKey(), kLogDescription, "https://test.example.com"));
+    scoped_refptr<const CTLogVerifier> log(
+        CTLogVerifier::Create(ct::GetTestPublicKey(), kLogDescription,
+                              "https://test.example.com", nullptr));

[eroman, 2016/07/18 17:09:46]

Same comment throughout (nullptr is not distinguishable from empty string, which
makes this misleading I think).

[Rob Percival, 2016/07/18 18:19:47]

Done.

     ASSERT_TRUE(log);
     log_verifiers_.push_back(log);
 
     ct_verifier_.reset(new MultiLogCTVerifier());
     ct_verifier_->AddLogs(log_verifiers_);
 
     ASSERT_NO_FATAL_FAILURE(GetTestCertificates(&certs_));
   }
 
   scoped_refptr<X509Certificate> GetTestServerCertificate() {
@@ skipping 449 matching lines @@
   ProofVerifyDetailsChromium* verify_details =
       static_cast<ProofVerifyDetailsChromium*>(details_.get());
   EXPECT_TRUE(verify_details->cert_verify_result.cert_status &
               CERT_STATUS_PINNED_KEY_MISSING);
   EXPECT_TRUE(verify_details->cert_verify_result.cert_status &
               CERT_STATUS_CERTIFICATE_TRANSPARENCY_REQUIRED);
 }
 
 }  // namespace test
 }  // namespace net