Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2108823006: skiaserve: Use snakeCase for JSON identifiers. (Closed)

Created:
4 years, 5 months ago by jcgregorio
Modified:
4 years, 5 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

skiaserve: Use snakeCase for JSON identifiers. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108823006 Committed: https://skia.googlesource.com/skia/+/ee0c555797608ce60716549cb4aa9d37d5c09745

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/debugger/SkDrawCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
jcgregorio
Sorry I missed this on the initial review.
4 years, 5 months ago (2016-06-30 14:47:04 UTC) #3
reed1
lgtm
4 years, 5 months ago (2016-06-30 14:47:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108823006/1
4 years, 5 months ago (2016-06-30 15:38:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/ee0c555797608ce60716549cb4aa9d37d5c09745
4 years, 5 months ago (2016-06-30 16:18:32 UTC) #8
jcgregorio
4 years, 5 months ago (2016-06-30 17:22:15 UTC) #9
Message was sent while issue was closed. 
On 2016/06/30 at 16:18:32, commit-bot wrote:
> Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ee0c555797608ce60716549cb4aa9d37d5c09745

Pushed to prod.

Powered by Google App Engine
This is Rietveld 408576698