Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: ui/login/account_picker/user_pod_template.html

Issue 2108813002: Added strings of i18n and made the pin-keyboard work for rtl lang. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Fixed patch set 3 errors. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/login/account_picker/user_pod_template.html
diff --git a/ui/login/account_picker/user_pod_template.html b/ui/login/account_picker/user_pod_template.html
index b319521faf8a7b5a27c97d9fa484bcf1b2d81def..09c1fbde22d54de1a9b8d2ac458b62eb4fe23ffe 100644
--- a/ui/login/account_picker/user_pod_template.html
+++ b/ui/login/account_picker/user_pod_template.html
@@ -11,7 +11,9 @@
</div>
</div>
<div class="pin-container pin-disabled">
- <pin-keyboard></pin-keyboard>
+ <pin-keyboard placeholder="$i18n{pinKeyboardPlaceholderPinPassword}"
jdufault 2016/06/28 23:06:10 Remove placeholder attribute, have the pin-keyboar
sammiequon 2016/06/29 19:44:08 Done.
+ enable-password="true">
jdufault 2016/06/28 23:06:10 nit: just enable-password
sammiequon 2016/06/29 19:44:08 Done.
+ </pin-keyboard>
</div>
<div class="main-pane">
<div class="name-container">
« ui/login/account_picker/user_pod_row.css ('K') | « ui/login/account_picker/user_pod_row.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698