chrome/browser/resources/settings/people_page/people_page.html - Issue 2108813002: Added strings of i18n and made the pin-keyboard work for rtl lang.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/people_page.html

Issue 2108813002: Added strings of i18n and made the pin-keyboard work for rtl lang. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Fixed patch set 3 errors. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js ('K') | « chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js ('k') | chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc » ('j') | chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/people_page/people_page.html

diff --git a/chrome/browser/resources/settings/people_page/people_page.html b/chrome/browser/resources/settings/people_page/people_page.html

index 56dda11a553edd831dc59d6842002eacb1d847c4..49f8db4f220f5dd7886318a8bd06e9cf921d0c55 100644

--- a/chrome/browser/resources/settings/people_page/people_page.html

+++ b/chrome/browser/resources/settings/people_page/people_page.html

@@ -162,7 +162,8 @@

<p>Quick Unlock PIN</p>

- <pin-keyboard></pin-keyboard>

+ <pin-keyboard placeholder="$i18n{pinKeyboardPlaceholderPin}">

jdufault 2016/06/28 23:06:10 Drop this change; placeholder should be driven by

sammiequon 2016/06/29 19:44:08 Done.

+ </pin-keyboard>

</div>

</template>