Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html

Issue 2108813002: Added strings of i18n and made the pin-keyboard work for rtl lang. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Added comment. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
diff --git a/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html b/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
index 3e11127c88f77cb4ae9ebe5bcc67f79b487a93c4..37cc0ec01e00d6746c397099e3e6ca36f42a8f49 100644
--- a/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
+++ b/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
@@ -2,6 +2,7 @@
what i18n to use for keypad, ie, does 1 ABC make
sense in every scenario? -->
+<link rel="import" href="chrome://resources/html/i18n_behavior.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/paper-styles.html">
@@ -11,9 +12,14 @@
<template>
<style>
#root {
+ direction: ltr;
display: flex;
}
+ .input-non-pin {
+ direction: rtl;
+ }
+
.row {
display: flex;
}
@@ -103,7 +109,9 @@
<div id="root">
<div id="container-constrained-width">
<div class="row horizontal-center">
- <input id="pin-input" type="number" placeholder="Enter PIN"
+ <input id="pin-input" type="[[computeInputType_(enablePassword)]]"
+ class$="[[computeInputClass_(value)]]"
+ placeholder="[[computeInputPlaceholder_(enablePassword)]]"
value="{{value::input}}"
on-keydown="onInputKeyDown_"></input>
<div class="digit-button first-row">
@@ -118,47 +126,49 @@
<div class="row keyboard">
<paper-button class="digit-button" on-tap="onNumberTap_" value="1">
- <inner-text>1</inner-text>
+ <inner-text>$i18n{pinKeyboard1}</inner-text>
</paper-button>
<paper-button class="digit-button" on-tap="onNumberTap_" value="2">
- <inner-text>2</inner-text>
+ <inner-text>$i18n{pinKeyboard2}</inner-text>
</paper-button>
<paper-button class="digit-button" on-tap="onNumberTap_" value="3">
- <inner-text>3</inner-text>
+ <inner-text>$i18n{pinKeyboard3}</inner-text>
</paper-button>
</div>
<div class="row keyboard">
<paper-button class="digit-button" on-tap="onNumberTap_" value="4">
- <inner-text>4</inner-text>
+ <inner-text>$i18n{pinKeyboard4}</inner-text>
</paper-button>
<paper-button class="digit-button" on-tap="onNumberTap_" value="5">
- <inner-text>5</inner-text>
+ <inner-text>$i18n{pinKeyboard5}</inner-text>
</paper-button>
<paper-button class="digit-button" on-tap="onNumberTap_" value="6">
- <inner-text>6</inner-text>
+ <inner-text>$i18n{pinKeyboard6}</inner-text>
</paper-button>
</div>
<div class="row keyboard">
<paper-button class="digit-button" on-tap="onNumberTap_" value="7">
- <inner-text>7</inner-text>
+ <inner-text>$i18n{pinKeyboard7}</inner-text>
</paper-button>
<paper-button class="digit-button" on-tap="onNumberTap_" value="8">
- <inner-text>8</inner-text>
+ <inner-text>$i18n{pinKeyboard8}</inner-text>
</paper-button>
<paper-button class="digit-button" on-tap="onNumberTap_" value="9">
- <inner-text>9</inner-text>
+ <inner-text>$i18n{pinKeyboard9}</inner-text>
</paper-button>
</div>
<div class="row keyboard">
<div class="digit-button"></div>
<paper-button class="digit-button" on-tap="onNumberTap_" value="0">
- <inner-text>0</inner-text>
+ <inner-text>$i18n{pinKeyboard0}</inner-text>
</paper-button>
<paper-button class="digit-button clear-button" on-tap="onPinClear_">
<div class="icon-container">
<iron-icon class="icon" icon="icons:clear"><iron-icon>
</div>
- <inner-text class="icon-subheading">Clear</inner-text>
+ <inner-text class="icon-subheading">
+ $i18n{pinKeyboardClear}
+ </inner-text>
</paper-button>
</div>
</div>

Powered by Google App Engine
This is Rietveld 408576698