Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: ui/login/account_picker/user_pod_template.html

Issue 2108813002: Added strings of i18n and made the pin-keyboard work for rtl lang. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/login/account_picker/user_pod_template.html
diff --git a/ui/login/account_picker/user_pod_template.html b/ui/login/account_picker/user_pod_template.html
index b319521faf8a7b5a27c97d9fa484bcf1b2d81def..81d9ebc39ce1d76db44bf2ebadd3e1e9a48829cf 100644
--- a/ui/login/account_picker/user_pod_template.html
+++ b/ui/login/account_picker/user_pod_template.html
@@ -11,7 +11,7 @@
</div>
</div>
<div class="pin-container pin-disabled">
- <pin-keyboard></pin-keyboard>
+ <pin-keyboard type="password"></pin-keyboard>
jdufault 2016/06/28 18:38:47 What about an enable-password boolean property?
sammiequon 2016/06/28 20:59:31 Done. Does not seem to let me use - or capitalize
jdufault 2016/06/28 21:13:22 See the "Property name to attribute name mapping"
sammiequon 2016/06/28 22:43:38 Done.
</div>
<div class="main-pane">
<div class="name-container">

Powered by Google App Engine
This is Rietveld 408576698