content/renderer/devtools/devtools_agent.cc - Issue 2108803006: Fix inspector overlay when use-zoom-for-dsf is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/devtools/devtools_agent.cc

Issue 2108803006: Fix inspector overlay when use-zoom-for-dsf is enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove unnecessary include Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/devtools/devtools_agent.cc

diff --git a/content/renderer/devtools/devtools_agent.cc b/content/renderer/devtools/devtools_agent.cc

index 27b7c32d6b2193a75383d4516e5deccef8c31a03..858e75fd0b95aa98704bc88a7350b9ef0ea5285f 100644

--- a/content/renderer/devtools/devtools_agent.cc

+++ b/content/renderer/devtools/devtools_agent.cc

@@ -22,6 +22,7 @@

#include "content/renderer/render_frame_impl.h"

#include "content/renderer/render_widget.h"

#include "ipc/ipc_channel.h"

+#include "third_party/WebKit/public/platform/WebFloatRect.h"

#include "third_party/WebKit/public/platform/WebPoint.h"

#include "third_party/WebKit/public/platform/WebString.h"

#include "third_party/WebKit/public/web/WebDevToolsAgent.h"

@@ -262,7 +263,9 @@ void DevToolsAgent::OnDispatchOnInspectorBackend(int session_id,

}

void DevToolsAgent::OnInspectElement(int x, int y) {

- GetWebAgent()->inspectElementAt(WebPoint(x, y));

+ blink::WebFloatRect point_rect(x, y, 0, 0);

+ frame_->GetRenderWidget()->convertWindowToViewport(&point_rect);

+ GetWebAgent()->inspectElementAt(WebPoint(point_rect.x, point_rect.y));

}

void DevToolsAgent::OnRequestNewWindowACK(bool success) {

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp » ('j') | third_party/WebKit/Source/web/InspectorOverlay.cpp » ('J')