Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: third_party/WebKit/Source/web/InspectorOverlay.cpp

Issue 2108803006: Fix inspector overlay when use-zoom-for-dsf is enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix crash when FrameView is null Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/InspectorOverlay.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/InspectorOverlay.cpp
diff --git a/third_party/WebKit/Source/web/InspectorOverlay.cpp b/third_party/WebKit/Source/web/InspectorOverlay.cpp
index 795309b67d7bca53c075e5d11263dec0e9659ddf..25e495b556c99084ad8478acac78eb3b183dd04b 100644
--- a/third_party/WebKit/Source/web/InspectorOverlay.cpp
+++ b/third_party/WebKit/Source/web/InspectorOverlay.cpp
@@ -389,8 +389,7 @@ void InspectorOverlay::rebuildOverlayPage()
LocalFrame* frame = toLocalFrame(overlayPage()->mainFrame());
frame->view()->resize(viewportSize);
overlayPage()->frameHost().visualViewport().setSize(viewportSize);
- float windowToViewportScale = m_webViewImpl->chromeClient().windowToViewportScalar(1.0f);
- frame->setPageZoomFactor(windowToViewportScale);
+ frame->setPageZoomFactor(windowToViewportScale());
reset(viewportSize, visibleRectInDocument.location());
@@ -446,7 +445,7 @@ void InspectorOverlay::drawQuadHighlight()
if (!m_highlightQuad)
return;
- InspectorHighlight highlight;
+ InspectorHighlight highlight(windowToViewportScale());
highlight.appendQuad(*m_highlightQuad, m_quadHighlightConfig.content, m_quadHighlightConfig.contentOutline);
evaluateInOverlay("drawHighlight", highlight.asProtocolValue());
}
@@ -463,6 +462,11 @@ void InspectorOverlay::drawViewSize()
evaluateInOverlay("drawViewSize", "");
}
+float InspectorOverlay::windowToViewportScale() const
+{
+ return m_webViewImpl->chromeClient().windowToViewportScalar(1.0f);
+}
+
Page* InspectorOverlay::overlayPage()
{
if (m_overlayPage)
@@ -544,8 +548,7 @@ void InspectorOverlay::reset(const IntSize& viewportSize, const IntPoint& docume
// The zoom factor in the overlay frame already has been multiplied by the window to viewport scale
// (aka device scale factor), so cancel it.
- float windowToViewportScale = m_webViewImpl->chromeClient().windowToViewportScalar(1.0f);
- resetData->setNumber("pageZoomFactor", m_webViewImpl->mainFrameImpl()->frame()->pageZoomFactor() / windowToViewportScale);
+ resetData->setNumber("pageZoomFactor", m_webViewImpl->mainFrameImpl()->frame()->pageZoomFactor() / windowToViewportScale());
resetData->setNumber("scrollX", documentScrollOffset.x());
resetData->setNumber("scrollY", documentScrollOffset.y());
« no previous file with comments | « third_party/WebKit/Source/web/InspectorOverlay.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698